Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in VF generate from glyphs source #1039

Open
aminabedi68 opened this issue Sep 20, 2023 · 1 comment
Open

error in VF generate from glyphs source #1039

aminabedi68 opened this issue Sep 20, 2023 · 1 comment

Comments

@aminabedi68
Copy link

Hi
with this source i see this error log:

C:\Users\cyber\Downloads>fontmake -o variable -g Dabir.glyphs
INFO:fontmake.font_project:Building master UFOs and designspace from Glyphs source
INFO:glyphsLib.parser:Parsing .glyphs file
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\Users\cyber\AppData\Local\Programs\Python\Python311\Scripts\fontmake.exe\__main__.py", line 7, in <module>
  File "C:\Users\cyber\AppData\Local\Programs\Python\Python311\Lib\site-packages\fontmake\__main__.py", line 656, in main
    project.run_from_glyphs(inputs.glyphs_path, **args)
  File "C:\Users\cyber\AppData\Local\Programs\Python\Python311\Lib\site-packages\fontmake\font_project.py", line 823, in run_from_glyphs
    designspace_path = self.build_master_ufos(
                       ^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\cyber\AppData\Local\Programs\Python\Python311\Lib\site-packages\fontTools\misc\loggingTools.py", line 375, in wrapper
    return func(*args, **kwds)
           ^^^^^^^^^^^^^^^^^^^
  File "C:\Users\cyber\AppData\Local\Programs\Python\Python311\Lib\site-packages\fontmake\font_project.py", line 223, in build_master_ufos
    designspace = glyphsLib.to_designspace(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\cyber\AppData\Local\Programs\Python\Python311\Lib\site-packages\glyphsLib\builder\__init__.py", line 130, in to_designspace
    return builder.designspace
           ^^^^^^^^^^^^^^^^^^^
  File "C:\Users\cyber\AppData\Local\Programs\Python\Python311\Lib\site-packages\glyphsLib\builder\builders.py", line 334, in designspace
    list(self.masters)  # Make sure that the UFOs are built
    ^^^^^^^^^^^^^^^^^^
  File "C:\Users\cyber\AppData\Local\Programs\Python\Python311\Lib\site-packages\glyphsLib\builder\builders.py", line 209, in masters
    self.to_ufo_font_attributes(self.family_name)  # .font
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\cyber\AppData\Local\Programs\Python\Python311\Lib\site-packages\glyphsLib\builder\font.py", line 56, in to_ufo_font_attributes
    self.to_ufo_custom_params(ufo, font)  # .custom_params
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\cyber\AppData\Local\Programs\Python\Python311\Lib\site-packages\glyphsLib\builder\custom_params.py", line 1073, in to_ufo_custom_params
    handler.to_ufo(self, glyphs_proxy, ufo_proxy)
  File "C:\Users\cyber\AppData\Local\Programs\Python\Python311\Lib\site-packages\glyphsLib\builder\custom_params.py", line 247, in to_ufo
    ufo_value = self.value_to_ufo(glyphs_value)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\cyber\AppData\Local\Programs\Python\Python311\Lib\site-packages\glyphsLib\builder\custom_params.py", line 528, in to_ufo_gasp_table
    value = {int(k): int(v) for k, v in value.items()}
                                        ^^^^^^^^^^^
AttributeError: 'str' object has no attribute 'items'
@anthrotype
Copy link
Member

Probably related to googlefonts/glyphsLib#944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants