Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete futures on irregular stream shutdown #747

Open
acocuzzo opened this issue Jul 26, 2022 · 0 comments · May be fixed by #746
Open

Complete futures on irregular stream shutdown #747

acocuzzo opened this issue Jul 26, 2022 · 0 comments · May be fixed by #746
Assignees
@mukund-ananthu
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@acocuzzo
Copy link
Contributor

We should add logic to complete futures during irregular stream shutdown (when subscriber.close() is called, to prevent possible deadlocks.
@acocuzzo acocuzzo added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 26, 2022
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Jul 26, 2022
@acocuzzo acocuzzo linked a pull request Jul 26, 2022 that will close this issue
Draft
@acocuzzo acocuzzo changed the title Complete futures on streaming_pull_manager Complete futures on irregular stream shutdown Jul 26, 2022
@liuyunnnn liuyunnnn assigned pradn and unassigned liuyunnnn Oct 24, 2023
@hongalex hongalex added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mukund-ananthu mukund-ananthu

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Complete futures on shutdown acocuzzo/python-pubsub
5 participants
@pradn @hongalex @liuyunnnn @acocuzzo @mukund-ananthu