Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration option for logger #417

Open
dazuma opened this issue Apr 13, 2020 · 1 comment
Open

Configuration option for logger #417

dazuma opened this issue Apr 13, 2020 · 1 comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@dazuma
Copy link
Member

dazuma commented Apr 13, 2020

Currently logging in the client requires applying a monkey patch to gRPC. Instead, there should be a configuration in the generated libraries.
@dazuma dazuma added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Apr 13, 2020
@dazuma
Copy link
Member Author

dazuma commented Apr 28, 2020

This is going to be a bit of a challenge, because gRPC's logging setting is global rather than per-connection. We might need to use thread locals to simulate context. Deferring this for later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dazuma