Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically audit imports of generated clients to ensure that dependencies are explicitly declared and tested #1924

Open
parthea opened this issue Feb 2, 2024 · 2 comments
Open

Automatically audit imports of generated clients to ensure that dependencies are explicitly declared and tested #1924

parthea opened this issue Feb 2, 2024 · 2 comments
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@parthea
Copy link
Contributor

parthea commented Feb 2, 2024

#1922 captures the issue where google-auth is an undeclared dependency. We should audit to code to ensure that all dependencies are declared.
@parthea parthea added type: process A process-related concern. May include testing, release, or the like. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Feb 2, 2024
@vchudnov-g
Copy link
Contributor

In addition, if we could automate the audit process itself somehow, we can make it less likely something like this will occur should we ever add more dependencies.

@parthea
Copy link
Contributor Author

parthea commented Feb 6, 2024

See related issue googleapis/synthtool#1901 to also add this functionality downstream

@parthea parthea changed the title Audit imports of generated clients to ensure that dependencies are explicitly declared and tested Automatically audit imports of generated clients to ensure that dependencies are explicitly declared and tested Feb 8, 2024
@parthea parthea mentioned this issue Feb 8, 2024
Closed
@parthea parthea mentioned this issue Apr 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parthea @vchudnov-g