Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/testing: add package with sample testdata #1512

Open
julieqiu opened this issue May 13, 2024 · 0 comments
Open

internal/testing: add package with sample testdata #1512

julieqiu opened this issue May 13, 2024 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@julieqiu
Copy link
Member

There are several places where we need sample values for testing, which are currently constructed within the scope of an individual unit test.

We should add a package that provides sample values for use in tests. The intent is to make it easier to reason about the various test cases by using one example. Additionally, we can document the meaning for these various values.

This implementation was started in #1508.
@julieqiu julieqiu added the priority: p3 Desirable enhancement or fix. May not be included in next release. label May 13, 2024
@julieqiu julieqiu mentioned this issue May 13, 2024
Merged
julieqiu added a commit to julieqiu/gapic-generator-go that referenced this issue May 13, 2024
@julieqiu
chore(internal/snippets,gengapic): use sample values in tests
255f36d 
Refactor internal/snippets/snippets_test.go and
internal/gengapic/example_test.go to use the internal/testing/sample
package.

For googleapis#1512
julieqiu added a commit to julieqiu/gapic-generator-go that referenced this issue May 13, 2024
@julieqiu
chore(internal/snippets,gengapic): use sample values in tests
2102386 
Refactor internal/snippets/snippets_test.go and
internal/gengapic/example_test.go to use the internal/testing/sample
package.

For googleapis#1512
julieqiu added a commit to julieqiu/gapic-generator-go that referenced this issue May 13, 2024
@julieqiu
chore(internal/snippets,gengapic): use sample values in tests
9a1c4d9 
Refactor internal/snippets/snippets_test.go and
internal/gengapic/example_test.go to use the internal/testing/sample
package.

For googleapis#1512
julieqiu added a commit to julieqiu/gapic-generator-go that referenced this issue May 13, 2024
@julieqiu
chore(internal/snippets,gengapic): use sample values in tests
3b350ed 
Refactor internal/snippets/snippets_test.go and
internal/gengapic/example_test.go to use the internal/testing/sample
package.

For googleapis#1512
julieqiu added a commit to julieqiu/gapic-generator-go that referenced this issue May 13, 2024
@julieqiu
chore(snippets,gengapic): use sample values in tests
ebd03fc 
Refactor TestNewMetadata, TestToMetadataJSON and TestRegionTag in
internal/snippets/snippets_test.go to use the internal/testing/sample
package.

For googleapis#1512
@julieqiu julieqiu mentioned this issue May 13, 2024
Open
noahdietz pushed a commit that referenced this issue May 13, 2024
@julieqiu
chore(snippets,gengapic): use sample values in tests (#1513)
779cd45 
Refactor TestNewMetadata, TestToMetadataJSON and TestRegionTag in
internal/snippets/snippets_test.go to use the internal/testing/sample
package.

For #1512
@julieqiu julieqiu mentioned this issue May 14, 2024
Merged
julieqiu added a commit to julieqiu/gapic-generator-go that referenced this issue May 14, 2024
@julieqiu
chore(internal/snippets,gengapic): use sample values in tests
e2fc950 
Refactor internal/snippets/snippets_test.go and
internal/gengapic/example_test.go to use the internal/testing/sample
package.

For googleapis#1512
@julieqiu julieqiu added the type: cleanup An internal cleanup or hygiene concern. label May 14, 2024
noahdietz pushed a commit that referenced this issue May 14, 2024
@julieqiu
chore(internal/snippets,gengapic): use sample values in tests (#1514)
8c289e4 
Refactor internal/snippets/snippets_test.go and
internal/gengapic/example_test.go to use the internal/testing/sample
package.

For #1512
This was referenced May 14, 2024
Merged
Merged
julieqiu added a commit to julieqiu/gapic-generator-go that referenced this issue May 14, 2024
@julieqiu
chore(internal/testing): update ServiceConfig with additional values
b0c3b46 
For googleapis#1512
julieqiu added a commit to julieqiu/gapic-generator-go that referenced this issue May 14, 2024
@julieqiu
chore(internal/testing): update ServiceConfig with additional values
d7d26cc 
For googleapis#1512
julieqiu added a commit to julieqiu/gapic-generator-go that referenced this issue May 14, 2024
@julieqiu
chore(internal/testing): update ServiceConfig with additional values
f0eda60 
For googleapis#1512
julieqiu added a commit to julieqiu/gapic-generator-go that referenced this issue May 15, 2024
@julieqiu
chore(internal/testing): update ServiceConfig with additional values
6a8d1b7 
For googleapis#1512
julieqiu added a commit that referenced this issue May 15, 2024
@julieqiu
chore(internal/testing): update ServiceConfig with additional values (#…
b455b1d 
…1519)

* chore(internal/testing): update ServiceConfig with additional values

For #1512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@julieqiu