Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] std::lsb should be parametric on signedness #1838

Open
dank-openai opened this issue Jan 10, 2025 · 0 comments · May be fixed by #1839
Open

[enhancement] std::lsb should be parametric on signedness #1838

dank-openai opened this issue Jan 10, 2025 · 0 comments · May be fixed by #1839
Assignees
@cdleary
Labels
dslx DSLX (domain specific language) implementation / front-end enhancement New feature or request

Comments

@dank-openai
Copy link

dank-openai commented Jan 10, 2025 •
edited
Loading

in addition to lsb, std::msb should also be generalized, and maybe more std lib functions too (I didn't think too deeply about it).

Current best alternative workaround (limit 100 words)

cast the value to unsigned, then use lsb

Your view of the "best case XLS enhancement" (limit 100 words)

std lib is updated, with some arguments allowed to be parametric signedness
@dank-openai dank-openai added the enhancement New feature or request label Jan 10, 2025
@cdleary cdleary added the dslx DSLX (domain specific language) implementation / front-end label Jan 10, 2025
@cdleary cdleary linked a pull request Jan 10, 2025 that will close this issue
Open
@cdleary cdleary self-assigned this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdleary cdleary

Labels
dslx DSLX (domain specific language) implementation / front-end enhancement New feature or request
Projects
XLS usability
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DSLX] Make lsb and msb in stdlib sign-parametric, fix fuzz failure. xlsynth/xlsynth
2 participants
@cdleary @dank-openai