New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpu_fast_attention not passing segment_ids to jax pallas attention mha #30

Open

Cjkkkk opened this issue Oct 2, 2023 · 0 comments

Cjkkkk commented Oct 2, 2023 •

edited

Loading

praxis/praxis/layers/gpu_fast_attention.py

Line 133 in 43db271

q, k, v, sm_scale=1.0 / math.sqrt(h), backward_pass_impl=bwd_pass_impl

https://github.com/google/jax/blame/main/jax/experimental/pallas/ops/attention.py#L163
seems like jax has added segment_ids as required argument but praxis has not updated to add the argument

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment