-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deeply nested SNP Report type #91
Comments
That is a breaking change that would need to get in before this tool gets wide use and the message type depended on. No more breaking schema changes would be allowed after 1.0. I'm open to this, seeing as we don't have any separate message consumption jobs that we would need to worry about versioning. So, signer_info, platform_info, all the tcbs, and policy all should have interpretation messages looks like. I think I would prefer to have those interpretations as new field numbers while marking the raw values as deprecated for removal before v1.0. What do you think? |
Great! That sounds good to me. |
Before we go too deep into changing up this format, I do want to say that I'm working with the RATS CoRIM folks to see if we can map all these fields into that, in which case the bit fields will indeed be split out into different named fields. |
Hey,
currently the Report type does not parse the nested types it includes. For example the TCB versions included are parsed as
uint64
and require another function to parse the included data from the field.How do you feel about accepting a contribution that would change the existing
Report
type to a nested type that includes subtypes likeTCBParts
? It seems to me like this would change the layout of the lib in a few places, hence the question.Best,
Otto
The text was updated successfully, but these errors were encountered: