Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructor names are not compared #87

Open
sergiords opened this issue Feb 2, 2016 · 0 comments
Open

Constructor names are not compared #87

sergiords opened this issue Feb 2, 2016 · 0 comments
Labels
P3 type=enhancement Make an existing feature better

Comments

@sergiords
Copy link

Truth.assertAbout(JavaSourcesSubjectFactory.javaSources())
                .that(givenJavaFile)
                .processedWith(someProcessor)
                .compilesWithoutError()
                .and()
                .generatesSources(expectedJavaFile);

Expected and generated constructor names are not compared.
Obviously it will fail later at generated source compilation if name is wrong, but it would be nice to detect it in generated sources comparison to make tests fail if such error occurs.

Generated:

public class Generated {
  public Generated() {
  }
}

Expected:

public class Generated {
  public GeneratedWithBadName() {
  }
}

With the previous examples, comparison does not fail.

@sergiords sergiords changed the title Failure to compare constructor name Constructor names are not compared Feb 2, 2016
@raghsriniv raghsriniv added the P3 label Jun 26, 2019
@cgdecker cgdecker added the type=enhancement Make an existing feature better label Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 type=enhancement Make an existing feature better
Projects
None yet
Development

No branches or pull requests

4 participants