diff --git a/src/client/linux/handler/minidump_descriptor.h b/src/client/linux/handler/minidump_descriptor.h index d822c9d92..1fbcaccfd 100644 --- a/src/client/linux/handler/minidump_descriptor.h +++ b/src/client/linux/handler/minidump_descriptor.h @@ -30,9 +30,9 @@ #define CLIENT_LINUX_HANDLER_MINIDUMP_DESCRIPTOR_H_ #include +#include #include -#include #include #include "client/linux/handler/microdump_extra_info.h" diff --git a/src/client/linux/minidump_writer/pe_structs.h b/src/client/linux/minidump_writer/pe_structs.h index 122cc2956..017ac0619 100644 --- a/src/client/linux/minidump_writer/pe_structs.h +++ b/src/client/linux/minidump_writer/pe_structs.h @@ -29,7 +29,7 @@ #ifndef CLIENT_LINUX_MINIDUMP_WRITER_PE_STRUCTS_H_ #define CLIENT_LINUX_MINIDUMP_WRITER_PE_STRUCTS_H_ -#include +#include namespace google_breakpad { @@ -222,4 +222,4 @@ typedef struct _RSDS_DEBUG_FORMAT { } // namespace google_breakpad -#endif // CLIENT_LINUX_MINIDUMP_WRITER_PE_STRUCTS_H_ \ No newline at end of file +#endif // CLIENT_LINUX_MINIDUMP_WRITER_PE_STRUCTS_H_ diff --git a/src/client/mac/crash_generation/Inspector.mm b/src/client/mac/crash_generation/Inspector.mm index 8d4e3e98b..4c0a78062 100644 --- a/src/client/mac/crash_generation/Inspector.mm +++ b/src/client/mac/crash_generation/Inspector.mm @@ -28,26 +28,23 @@ // // Utility that can inspect another process and write a crash dump -#include -#include +#import "client/mac/crash_generation/Inspector.h" + +#import #include #include #include -#include -#import "client/mac/crash_generation/Inspector.h" +#include +#include +#import "GTMDefines.h" #import "client/mac/Framework/Breakpad.h" #import "client/mac/handler/minidump_generator.h" - #import "common/mac/MachIPC.h" #include "common/mac/bootstrap_compat.h" #include "common/mac/launch_reporter.h" -#import "GTMDefines.h" - -#import - namespace google_breakpad { //============================================================================= @@ -358,4 +355,3 @@ } } // namespace google_breakpad - diff --git a/src/client/mac/handler/minidump_generator.cc b/src/client/mac/handler/minidump_generator.cc index fd863aea9..f30742160 100644 --- a/src/client/mac/handler/minidump_generator.cc +++ b/src/client/mac/handler/minidump_generator.cc @@ -30,20 +30,19 @@ #include // Must come first #endif -#include -#include +#include "client/mac/handler/minidump_generator.h" +#include +#include +#include #include #include #include -#include -#include -#include +#include #include +#include -#include - -#include "client/mac/handler/minidump_generator.h" +#include #if defined(HAS_ARM_SUPPORT) || defined(HAS_ARM64_SUPPORT) #include @@ -1071,9 +1070,8 @@ bool MinidumpGenerator::WriteMemoryListStream( ip_memory_d.start_of_memory_range = std::max(uintptr_t(addr), uintptr_t(ip - (kIPMemorySize / 2))); - uintptr_t end_of_range = - std::min(uintptr_t(ip + (kIPMemorySize / 2)), - uintptr_t(addr + size)); + uintptr_t end_of_range = std::min(uintptr_t(ip + (kIPMemorySize / 2)), + uintptr_t(addr + size)); uintptr_t range_diff = end_of_range - static_cast(ip_memory_d.start_of_memory_range); ip_memory_d.memory.data_size = static_cast(range_diff); diff --git a/src/client/solaris/handler/exception_handler.cc b/src/client/solaris/handler/exception_handler.cc index 0e5f44976..e3688581a 100644 --- a/src/client/solaris/handler/exception_handler.cc +++ b/src/client/solaris/handler/exception_handler.cc @@ -32,16 +32,16 @@ #include // Must come first #endif +#include "client/solaris/handler/exception_handler.h" + +#include #include +#include #include #include +#include #include -#include -#include -#include - -#include "client/solaris/handler/exception_handler.h" #include "common/solaris/guid_creator.h" #include "common/solaris/message_output.h" #include "google_breakpad/common/minidump_format.h" diff --git a/src/client/solaris/handler/exception_handler_test.cc b/src/client/solaris/handler/exception_handler_test.cc index 3d656820d..56ef94dd0 100644 --- a/src/client/solaris/handler/exception_handler_test.cc +++ b/src/client/solaris/handler/exception_handler_test.cc @@ -32,15 +32,15 @@ #include // Must come first #endif +#include "client/solaris/handler/exception_handler.h" + +#include #include +#include +#include +#include #include -#include -#include -#include -#include - -#include "client/solaris/handler/exception_handler.h" #include "client/solaris/handler/solaris_lwp.h" using namespace google_breakpad; diff --git a/src/client/solaris/handler/minidump_generator.cc b/src/client/solaris/handler/minidump_generator.cc index 5d24d0ae8..f9e1adfc6 100644 --- a/src/client/solaris/handler/minidump_generator.cc +++ b/src/client/solaris/handler/minidump_generator.cc @@ -32,18 +32,18 @@ #include // Must come first #endif +#include "client/solaris/handler/minidump_generator.h" + #include +#include #include #include #include #include #include +#include #include -#include -#include - -#include "client/solaris/handler/minidump_generator.h" #include "client/minidump_file_writer-inl.h" #include "common/solaris/file_id.h" @@ -337,7 +337,7 @@ bool WriteCPUInformation(MDRawSystemInfo* sys_info) { build = strchr(uts.version, '_'); ++build; sys_info->build_number = atoi(build); - + return true; } @@ -596,8 +596,8 @@ bool WriteExceptionStream(MinidumpFileWriter* minidump_writer, #if TARGET_CPU_SPARC if (writer_args->sig_ctx != NULL) { - exception.get()->exception_record.exception_address = - writer_args->sig_ctx->uc_mcontext.gregs[REG_PC]; + exception.get()->exception_record.exception_address = + writer_args->sig_ctx->uc_mcontext.gregs[REG_PC]; } else { return true; } @@ -700,14 +700,14 @@ void* Write(void* argument) { if (writer_args->sighandler_ebp != 0 && writer_args->lwp_lister->FindSigContext(writer_args->sighandler_ebp, &writer_args->sig_ctx)) { - writer_args->crashed_stack_bottom = - writer_args->lwp_lister->GetLwpStackBottom( + writer_args->crashed_stack_bottom = + writer_args->lwp_lister->GetLwpStackBottom( #if TARGET_CPU_SPARC - writer_args->sig_ctx->uc_mcontext.gregs[REG_O6] + writer_args->sig_ctx->uc_mcontext.gregs[REG_O6] #elif TARGET_CPU_X86 - writer_args->sig_ctx->uc_mcontext.gregs[UESP] + writer_args->sig_ctx->uc_mcontext.gregs[UESP] #endif - ); + ); int crashed_lwpid = FindCrashingLwp(writer_args->crashed_stack_bottom, writer_args->requester_pid, diff --git a/src/client/solaris/handler/solaris_lwp.cc b/src/client/solaris/handler/solaris_lwp.cc index 02f1c37e8..fec9e3f3e 100644 --- a/src/client/solaris/handler/solaris_lwp.cc +++ b/src/client/solaris/handler/solaris_lwp.cc @@ -32,11 +32,16 @@ #include // Must come first #endif +#include "client/solaris/handler/solaris_lwp.h" + +#include #include #include #include #include #include +#include +#include #include #include #include @@ -44,12 +49,8 @@ #include #include -#include -#include -#include #include -#include "client/solaris/handler/solaris_lwp.h" #include "common/solaris/message_output.h" using namespace google_breakpad; @@ -320,7 +321,7 @@ int SolarisLwp::ListModules( return -1; /* - * Determine number of mappings, this value must be + * Determine number of mappings, this value must be * larger than the actual module count */ size = status.st_size; @@ -337,7 +338,7 @@ int SolarisLwp::ListModules( prmap_t* _maps; int _num; int module_count = 0; - + /* * Scan each mapping - note it is assummed that the mappings are * presented in order. We fill holes between mappings. On intel diff --git a/src/client/windows/crash_generation/crash_generation_client.cc b/src/client/windows/crash_generation/crash_generation_client.cc index c3d6a2bc8..653fafdc2 100644 --- a/src/client/windows/crash_generation/crash_generation_client.cc +++ b/src/client/windows/crash_generation/crash_generation_client.cc @@ -31,8 +31,11 @@ #endif #include "client/windows/crash_generation/crash_generation_client.h" -#include + +#include + #include + #include "client/windows/common/ipc_protocol.h" namespace google_breakpad { diff --git a/src/client/windows/crash_generation/crash_generation_server.cc b/src/client/windows/crash_generation/crash_generation_server.cc index 61b0cbc0b..1e7a6ca70 100644 --- a/src/client/windows/crash_generation/crash_generation_server.cc +++ b/src/client/windows/crash_generation/crash_generation_server.cc @@ -31,12 +31,15 @@ #endif #include "client/windows/crash_generation/crash_generation_server.h" + #include -#include + +#include + #include + #include "client/windows/common/auto_critical_section.h" #include "common/scoped_ptr.h" - #include "client/windows/crash_generation/client_info.h" namespace google_breakpad { diff --git a/src/client/windows/handler/exception_handler.cc b/src/client/windows/handler/exception_handler.cc index 64b297999..bc56bd80b 100644 --- a/src/client/windows/handler/exception_handler.cc +++ b/src/client/windows/handler/exception_handler.cc @@ -30,17 +30,17 @@ #include // Must come first #endif +#include "client/windows/handler/exception_handler.h" + +#include #include +#include #include -#include -#include - -#include "common/windows/string_utils-inl.h" #include "client/windows/common/ipc_protocol.h" -#include "client/windows/handler/exception_handler.h" #include "common/windows/guid_string.h" +#include "common/windows/string_utils-inl.h" namespace google_breakpad { diff --git a/src/common/solaris/file_id.cc b/src/common/solaris/file_id.cc index 5a9982bb4..73b6acc22 100644 --- a/src/common/solaris/file_id.cc +++ b/src/common/solaris/file_id.cc @@ -36,20 +36,19 @@ #include // Must come first #endif +#include "common/solaris/file_id.h" + +#include #include #include #include -#include -#include #include #include +#include +#include #include -#include -#include - #include "common/md5.h" -#include "common/solaris/file_id.h" #include "common/solaris/message_output.h" #include "google_breakpad/common/minidump_format.h" diff --git a/src/common/solaris/guid_creator.cc b/src/common/solaris/guid_creator.cc index 998d24991..2cfe1b7b3 100644 --- a/src/common/solaris/guid_creator.cc +++ b/src/common/solaris/guid_creator.cc @@ -32,15 +32,14 @@ #include // Must come first #endif -#include -#include +#include "common/solaris/guid_creator.h" +#include #include #include +#include #include -#include "common/solaris/guid_creator.h" - // // GUIDGenerator // diff --git a/src/common/string_view.h b/src/common/string_view.h index a8e15922d..8b9b19e6e 100644 --- a/src/common/string_view.h +++ b/src/common/string_view.h @@ -29,9 +29,13 @@ #ifndef COMMON_STRING_VIEW_H__ #define COMMON_STRING_VIEW_H__ -#include -#include +#include +#include +#include + +#include #include + #include "common/using_std_string.h" namespace google_breakpad { diff --git a/src/common/windows/omap.cc b/src/common/windows/omap.cc index 1ffcec765..e707e1268 100644 --- a/src/common/windows/omap.cc +++ b/src/common/windows/omap.cc @@ -106,10 +106,10 @@ #include "common/windows/omap.h" +#include #include #include -#include #include #include "common/windows/dia_util.h" diff --git a/src/common/windows/string_utils.cc b/src/common/windows/string_utils.cc index 956ee9906..46d530ecf 100644 --- a/src/common/windows/string_utils.cc +++ b/src/common/windows/string_utils.cc @@ -30,13 +30,13 @@ #include // Must come first #endif +#include "common/windows/string_utils-inl.h" + +#include #include -#include #include -#include "common/windows/string_utils-inl.h" - namespace google_breakpad { // static diff --git a/src/common/windows/sym_upload_v2_protocol.cc b/src/common/windows/sym_upload_v2_protocol.cc index 450f3626b..ee3b1919e 100644 --- a/src/common/windows/sym_upload_v2_protocol.cc +++ b/src/common/windows/sym_upload_v2_protocol.cc @@ -32,7 +32,7 @@ #include "common/windows/sym_upload_v2_protocol.h" -#include +#include #include "common/windows/http_upload.h" #include "common/windows/symbol_collector_client.h" diff --git a/src/google_breakpad/processor/call_stack.h b/src/google_breakpad/processor/call_stack.h index 9bf062f83..a18f8f74b 100644 --- a/src/google_breakpad/processor/call_stack.h +++ b/src/google_breakpad/processor/call_stack.h @@ -44,7 +44,8 @@ #ifndef GOOGLE_BREAKPAD_PROCESSOR_CALL_STACK_H__ #define GOOGLE_BREAKPAD_PROCESSOR_CALL_STACK_H__ -#include +#include + #include namespace google_breakpad { diff --git a/src/processor/exploitability.cc b/src/processor/exploitability.cc index 89064c9b1..e8b817449 100644 --- a/src/processor/exploitability.cc +++ b/src/processor/exploitability.cc @@ -37,7 +37,7 @@ #include // Must come first #endif -#include +#include #include "common/scoped_ptr.h" #include "google_breakpad/processor/exploitability.h" diff --git a/src/processor/fast_source_line_resolver.cc b/src/processor/fast_source_line_resolver.cc index 1c329772d..044eea356 100644 --- a/src/processor/fast_source_line_resolver.cc +++ b/src/processor/fast_source_line_resolver.cc @@ -41,16 +41,17 @@ #endif #include "google_breakpad/processor/fast_source_line_resolver.h" -#include "processor/fast_source_line_resolver_types.h" -#include -#include +#include +#include + #include #include #include #include "common/scoped_ptr.h" #include "common/using_std_string.h" +#include "processor/fast_source_line_resolver_types.h" #include "processor/logging.h" #include "processor/module_factory.h" #include "processor/simple_serializer-inl.h" diff --git a/src/processor/fast_source_line_resolver_types.h b/src/processor/fast_source_line_resolver_types.h index 14913518b..ae58d7525 100644 --- a/src/processor/fast_source_line_resolver_types.h +++ b/src/processor/fast_source_line_resolver_types.h @@ -36,7 +36,8 @@ #ifndef PROCESSOR_FAST_SOURCE_LINE_RESOLVER_TYPES_H__ #define PROCESSOR_FAST_SOURCE_LINE_RESOLVER_TYPES_H__ -#include +#include + #include #include diff --git a/src/processor/map_serializers_unittest.cc b/src/processor/map_serializers_unittest.cc index 855c4dae1..c5228d647 100644 --- a/src/processor/map_serializers_unittest.cc +++ b/src/processor/map_serializers_unittest.cc @@ -31,12 +31,15 @@ // // Author: Siyang Xie (lambxsy@google.com) -#include #ifdef HAVE_CONFIG_H #include // Must come first #endif -#include +#include "map_serializers-inl.h" + +#include +#include + #include #include #include @@ -44,8 +47,6 @@ #include #include "breakpad_googletest_includes.h" -#include "map_serializers-inl.h" - #include "processor/address_map-inl.h" #include "processor/range_map-inl.h" #include "processor/contained_range_map-inl.h" diff --git a/src/processor/minidump.cc b/src/processor/minidump.cc index 22dce7626..d33522631 100644 --- a/src/processor/minidump.cc +++ b/src/processor/minidump.cc @@ -44,10 +44,10 @@ #include "google_breakpad/processor/minidump.h" #include -#include #include #include #include +#include #include #include @@ -62,8 +62,6 @@ #include #include -#include "processor/range_map-inl.h" - #include "common/macros.h" #include "common/scoped_ptr.h" #include "common/stdio_wrapper.h" @@ -72,6 +70,7 @@ #include "processor/basic_code_modules.h" #include "processor/convert_old_arm64_context.h" #include "processor/logging.h" +#include "processor/range_map-inl.h" namespace google_breakpad { diff --git a/src/processor/minidump_processor.cc b/src/processor/minidump_processor.cc index 44e69c890..b2166e652 100644 --- a/src/processor/minidump_processor.cc +++ b/src/processor/minidump_processor.cc @@ -33,10 +33,10 @@ #include "google_breakpad/processor/minidump_processor.h" #include +#include +#include #include -#include -#include #include #include #include diff --git a/src/processor/module_serializer.cc b/src/processor/module_serializer.cc index 33130353a..5a744a56c 100644 --- a/src/processor/module_serializer.cc +++ b/src/processor/module_serializer.cc @@ -38,8 +38,9 @@ #include "processor/module_serializer.h" -#include -#include +#include +#include + #include #include diff --git a/src/processor/module_serializer.h b/src/processor/module_serializer.h index 675d78488..eefe2857d 100644 --- a/src/processor/module_serializer.h +++ b/src/processor/module_serializer.h @@ -36,7 +36,8 @@ #ifndef PROCESSOR_MODULE_SERIALIZER_H__ #define PROCESSOR_MODULE_SERIALIZER_H__ -#include +#include + #include #include diff --git a/src/processor/simple_serializer-inl.h b/src/processor/simple_serializer-inl.h index bc2c8def2..30d0533bd 100644 --- a/src/processor/simple_serializer-inl.h +++ b/src/processor/simple_serializer-inl.h @@ -39,7 +39,8 @@ #include "processor/simple_serializer.h" -#include +#include + #include #include "google_breakpad/processor/basic_source_line_resolver.h" diff --git a/src/processor/stackwalker_arm64.cc b/src/processor/stackwalker_arm64.cc index 6c3168ecc..0fdc11018 100644 --- a/src/processor/stackwalker_arm64.cc +++ b/src/processor/stackwalker_arm64.cc @@ -36,7 +36,10 @@ #include // Must come first #endif -#include +#include "processor/stackwalker_arm64.h" + +#include + #include #include "common/scoped_ptr.h" @@ -46,7 +49,6 @@ #include "google_breakpad/processor/stack_frame_cpu.h" #include "processor/cfi_frame_info.h" #include "processor/logging.h" -#include "processor/stackwalker_arm64.h" namespace google_breakpad { diff --git a/src/processor/stackwalker_arm64.h b/src/processor/stackwalker_arm64.h index 193ab302a..933b557ff 100644 --- a/src/processor/stackwalker_arm64.h +++ b/src/processor/stackwalker_arm64.h @@ -41,6 +41,7 @@ #include "google_breakpad/common/breakpad_types.h" #include "google_breakpad/common/minidump_format.h" +#include "google_breakpad/processor/stack_frame_cpu.h" #include "google_breakpad/processor/stackwalker.h" namespace google_breakpad { diff --git a/src/processor/static_address_map_unittest.cc b/src/processor/static_address_map_unittest.cc index 2e8461675..d99833ce8 100644 --- a/src/processor/static_address_map_unittest.cc +++ b/src/processor/static_address_map_unittest.cc @@ -34,9 +34,12 @@ #include // Must come first #endif -#include -#include -#include +#include "processor/static_address_map-inl.h" + +#include +#include +#include + #include #include #include @@ -44,7 +47,6 @@ #include "breakpad_googletest_includes.h" #include "common/using_std_string.h" #include "processor/address_map-inl.h" -#include "processor/static_address_map-inl.h" #include "processor/simple_serializer-inl.h" #include "map_serializers-inl.h" diff --git a/src/processor/static_contained_range_map_unittest.cc b/src/processor/static_contained_range_map_unittest.cc index c6d78400d..b9ed72489 100644 --- a/src/processor/static_contained_range_map_unittest.cc +++ b/src/processor/static_contained_range_map_unittest.cc @@ -31,15 +31,17 @@ // // Author: Siyang Xie (lambxsy@google.com) -#include #ifdef HAVE_CONFIG_H #include // Must come first #endif +#include "processor/static_contained_range_map-inl.h" + +#include + #include "breakpad_googletest_includes.h" #include "common/scoped_ptr.h" #include "processor/contained_range_map-inl.h" -#include "processor/static_contained_range_map-inl.h" #include "processor/simple_serializer-inl.h" #include "processor/map_serializers-inl.h" #include "processor/logging.h" diff --git a/src/processor/static_map_unittest.cc b/src/processor/static_map_unittest.cc index 1fbb9a498..9308b04bd 100644 --- a/src/processor/static_map_unittest.cc +++ b/src/processor/static_map_unittest.cc @@ -30,17 +30,18 @@ // // Author: Siyang Xie (lambxsy@google.com) -#include #ifdef HAVE_CONFIG_H #include // Must come first #endif -#include +#include "processor/static_map-inl.h" + +#include +#include + #include #include "breakpad_googletest_includes.h" -#include "processor/static_map-inl.h" - typedef int ValueType; typedef int KeyType; diff --git a/src/tools/linux/dump_syms/dump_syms.cc b/src/tools/linux/dump_syms/dump_syms.cc index 007b46094..f5f89f410 100644 --- a/src/tools/linux/dump_syms/dump_syms.cc +++ b/src/tools/linux/dump_syms/dump_syms.cc @@ -32,9 +32,9 @@ #include #include +#include #include -#include #include #include #include diff --git a/src/tools/solaris/dump_syms/dump_syms.cc b/src/tools/solaris/dump_syms/dump_syms.cc index ead160011..8f5924ae2 100644 --- a/src/tools/solaris/dump_syms/dump_syms.cc +++ b/src/tools/solaris/dump_syms/dump_syms.cc @@ -32,11 +32,12 @@ #include // Must come first #endif -#include -#include - #include "common/solaris/dump_symbols.h" +#include + +#include + using namespace google_breakpad; int main(int argc, char** argv) { diff --git a/src/tools/windows/converter/ms_symbol_server_converter.cc b/src/tools/windows/converter/ms_symbol_server_converter.cc index f7d9d9431..d1a6b40d5 100644 --- a/src/tools/windows/converter/ms_symbol_server_converter.cc +++ b/src/tools/windows/converter/ms_symbol_server_converter.cc @@ -37,14 +37,15 @@ #include // Must come first #endif +#include "tools/windows/converter/ms_symbol_server_converter.h" + #include + +#include #include #include +#include -#include -#include - -#include "tools/windows/converter/ms_symbol_server_converter.h" #include "common/windows/pdb_source_line_writer.h" #include "common/windows/pe_source_line_writer.h" #include "common/windows/string_utils-inl.h" diff --git a/src/tools/windows/converter_exe/converter.cc b/src/tools/windows/converter_exe/converter.cc index 92c41774a..6d7664774 100644 --- a/src/tools/windows/converter_exe/converter.cc +++ b/src/tools/windows/converter_exe/converter.cc @@ -35,9 +35,10 @@ #include // Must come first #endif -#include -#include -#include +#include +#include +#include + #include #include #include diff --git a/src/tools/windows/symupload/symupload.cc b/src/tools/windows/symupload/symupload.cc index 20f48a277..52a915c30 100644 --- a/src/tools/windows/symupload/symupload.cc +++ b/src/tools/windows/symupload/symupload.cc @@ -47,18 +47,18 @@ #endif #include + #include +#include #include -#include #include #include #include -#include "common/windows/string_utils-inl.h" - #include "common/windows/http_upload.h" #include "common/windows/pdb_source_line_writer.h" +#include "common/windows/string_utils-inl.h" #include "common/windows/sym_upload_v2_protocol.h" #include "common/windows/symbol_collector_client.h"