We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thank you for your contribution. I found a little bug in mjpc/tasks/humanoid/walk/task.xml and walk.cc In line 33 and 34 of task.xml
mjpc/tasks/humanoid/walk/task.xml
walk.cc
task.xml
<user name="Velocity" dim="2" user="7 0.625 0 25.0 0.2 4.0" /> <user name="Walk" dim="1" user="7 1.0 0.0 25.0 0.5 3.0" />
The definition of "velocity" is before the definition of "walk" However in "walk.cc".
// com vel double* waist_lower_subcomvel = SensorByName(model, data, "waist_lower_subcomvel"); double* torso_velocity = SensorByName(model, data, "torso_velocity"); double com_vel[2]; mju_add(com_vel, waist_lower_subcomvel, torso_velocity, 2); mju_scl(com_vel, com_vel, 0.5, 2); // walk forward residual[counter++] = standing * (mju_dot(com_vel, forward, 2) - parameters_[1]); // ----- move feet ----- // double* foot_right_vel = SensorByName(model, data, "foot_right_velocity"); double* foot_left_vel = SensorByName(model, data, "foot_left_velocity"); double move_feet[2]; mju_copy(move_feet, com_vel, 2); mju_addToScl(move_feet, foot_right_vel, -0.5, 2); mju_addToScl(move_feet, foot_left_vel, -0.5, 2); mju_copy(&residual[counter], move_feet, 2); mju_scl(&residual[counter], &residual[counter], standing, 2); counter += 2;
It is reversed.
The text was updated successfully, but these errors were encountered:
Thanks for this!
Sorry, something went wrong.
Fix order of velocity and walk residual terms in humanoid walk task.x…
c165ae9
…ml. Fixes #359. PiperOrigin-RevId: 700304229 Change-Id: I1ab15337743a4c419aaee2f0863ed2fc82bd65e1
No branches or pull requests
Thank you for your contribution.
I found a little bug in
mjpc/tasks/humanoid/walk/task.xml
andwalk.cc
In line 33 and 34 of
task.xml
The definition of "velocity" is before the definition of "walk"
However in "walk.cc".
It is reversed.
The text was updated successfully, but these errors were encountered: