Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

A suggestion to modify the updateSegmentation.sh #3

Open
akshayc11 opened this issue Mar 29, 2018 · 2 comments
Open

A suggestion to modify the updateSegmentation.sh #3

akshayc11 opened this issue Mar 29, 2018 · 2 comments

Comments

@akshayc11
Copy link

If we make the assumption that the input text is going to be UTF-8 file format, I think that The following needs to be modified from

morfessor -l $lmDir/zeroth_morfessor.seg -T - -o - \

morfessor -l $lmDir/zeroth_morfessor.seg -T - -o - \
to
morfessor -e 'utf-8' -l $lmDir/zeroth_morfessor.seg -T - -o - \

This is because morfessor defaults to the assumption that the text is ASCII.

@akshayc11 akshayc11 reopened this Mar 29, 2018
@akshayc11
Copy link
Author

Can confirm that the ascii issue may actually be there...

@jty016
Copy link
Contributor

jty016 commented Mar 29, 2018

Thank you, @akshayc11. yes, I think this is good point.

According to the morfessor's help, they said.

-e <encoding>, --encoding <encoding>
    encoding of input and output files (if none is given, both the local encoding and UTF-8 are tried)

so that's why I provide locale setup at https://github.com/goodatlas/zeroth/wiki/Requirements

Anyway, I'll do a test for sure.
And If it is possible to you, plz make an official PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants