Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unbindComponentEvent doesn't get called when using "Embedded with Events" using "Application Ref" method #17

Open
cbranca opened this issue Mar 17, 2022 · 1 comment

Comments

@cbranca
Copy link

cbranca commented Mar 17, 2022

As the title says, the unbindComponentEvent doesn't get called when using "Embedded with Events" using "Application Ref" method.

The README of this repository says: "Earlier versions of this application used Golden Layout's getComponentEvent and releaseComponentEvent to implement the above "Embedded with Events" approach. These events are now deprecated. Please use the new bindComponentEvent and unbindComponentEvent events instead."

In my case, I need to do something inside unbindComponentEvent but it gets called only when using the virtual tecnique.

Is that a bug? should I need to use the deprecated releaseComponentEvent?

@pbklink
Copy link
Contributor

pbklink commented Mar 17, 2022

This was a due to a bug in golden-layout (golden-layout/golden-layout#739). This has been fixed in golden-layout release 2.5.0.

I have updated golden-layout-ng-app to use golden-layout 2.5.0. This bug should now no longer be present in this app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants