Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: add LUCI aix-ppc64 builder #67299

Open
dmitshur opened this issue May 10, 2024 · 15 comments
Open

x/build: add LUCI aix-ppc64 builder #67299

dmitshur opened this issue May 10, 2024 · 15 comments
Labels
arch-ppc64x Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. new-builder OS-AIX
Milestone

Comments

@dmitshur
Copy link
Contributor

There currently isn't a LUCI builder that tests the aix/ppc64 port (other than the misc-compile builder, which tests only that the port compiles). This is the tracking issue for it.

The next steps that a builder owner will need to follow to make progress here are documented https://go.dev/wiki/DashboardBuilders#luci-builders.

@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) OS-AIX new-builder arch-ppc64x labels May 10, 2024
@dmitshur dmitshur added this to the Unreleased milestone May 10, 2024
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 10, 2024
@laboger
Copy link
Contributor

laboger commented May 13, 2024

@ayappanec

@ayappanec
Copy link

We are working on getting a AIX machine in OSU lab for this purpose.

@dmitshur
Copy link
Contributor Author

CC @golang/aix.

@pmur
Copy link
Contributor

pmur commented Jul 24, 2024

I'll try poking around with this since I came into access to the VM.

I've chosen the hostname as aix-ppc64-power8, cert attached: aix-ppc64-power8.csr.txt

(edit: fix hostname to match prevailing conventions, edit 2: revert to original naming)

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/600995 mentions this issue: main.star: mark aix-ppc64 as fixed capacity

@dmitshur
Copy link
Contributor Author

dmitshur commented Jul 24, 2024

@pmur I see you've edited that post, replacing - with _. You were likely thinking of builder names, where underscores are indeed used to separate the OS version and/or runmods. But for hostnames we do use dashes everywhere. The ideal format is documented at https://go.dev/wiki/DashboardBuilders#how-to-set-up-a-builder as <GOOS>-<GOOARCH>-<GitHub handle of maintainer>. If it's not definitive who the maintainer will be, it's fine to go with just aix-ppc64-power8 as before since this is the first aix/ppc64 LUCI builder.

Are you okay to go back to aix-ppc64-power8 (or aix-ppc64-power8-maintainername) as the hostname?

@pmur
Copy link
Contributor

pmur commented Jul 24, 2024

Oops. I'd prefer to stick with aix-ppc64-power8 for consistency with the other builders I've inherited.

@dmitshur
Copy link
Contributor Author

dmitshur commented Jul 24, 2024

Thanks. Here's the certificate: aix-ppc64-power8-1721862086.cert.txt.

Also noting that if the previous coordinator-based builder starts to get in the way of you bringing up the new LUCI builder, you should feel free to stop the previous builder and focus on the new one. It's certainly fine to keep the old one running if it doesn't get in the way. Thanks.

gopherbot pushed a commit to golang/build that referenced this issue Jul 25, 2024
For golang/go#67299.

Change-Id: I76f511338617f6b431c396f048200d25e09dd275
Reviewed-on: https://go-review.googlesource.com/c/build/+/600995
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
@pmur
Copy link
Contributor

pmur commented Jul 25, 2024

I am still in the process of getting LUCI working. I had to update the OSS software, and that has been rather bumpy. I have the swarming client running, though I suspect I will need to solve more issues once the backend pieces are updated.

This has led to some (hopefully) intermittent failures of the old builder.

@pmur
Copy link
Contributor

pmur commented Aug 8, 2024

The LUCI aix bot is up, though I think something needs to be updated on the backend. It has not run any jobs yet. The cpu and cipd_platform values look suspect.

@dmitshur
Copy link
Contributor Author

dmitshur commented Aug 8, 2024

The cpu and cipd_platform values look suspect.

Indeed. The CIPD binaries built for GOOS=aix GOARCH=ppc64 are using "aix-ppc64" (https://chrome-infra-packages.appspot.com/p/infra/experimental/golangbuild/aix-ppc64), so it's intended for the bot to report its cipd_platform dimension as that (instead of the current "aix-00fac25f4b00"). That dimension is also used for match the bot to the builder definitions (e.g., gotip-aix-ppc64). There are zero matches at https://chromium-swarm.appspot.com/botlist?f=cipd_platform%3Aaix-ppc64&f=pool%3Aluci.golang.shared-workers now—hence the bot isn't getting any jobs.

@dmitshur
Copy link
Contributor Author

The aforementioned issue is fixed in crrev.com/c/5775509, thanks. A build for gotip-aix-ppc64 builder was now able to start at https://ci.chromium.org/b/8739762966790400417, failing with "CIPD error: invalid_version_error with package infra/tools/luci/cas/aix-ppc64, version git_revision:2aba496613f92a5b06d577f82b5d028225d3d577 on path None".

While we do have a aix-ppc64 binary for golangbuild (https://chrome-infra-packages.appspot.com/p/infra/experimental/golangbuild), there isn't one for some other dependencies like cas at https://chrome-infra-packages.appspot.com/p/infra/tools/luci/cas. We either need to get them built and selected, or possibly get by if there's a way this builder can operate in "low dependency" mode without needing them.

@dmitshur
Copy link
Contributor Author

dmitshur commented Aug 13, 2024

Other binaries like bb, rdb, result_adapter, and so on are already there. The reason we didn't end up with a cas binary built for aix/ppc64 is because it fails to build:

$ GOOS=aix GOARCH=ppc64 CGO_ENABLED=0 go install go.chromium.org/luci/client/cmd/cas@latest
# github.com/dgraph-io/badger/v3
go/pkg/mod/github.com/dgraph-io/badger/[email protected]/dir_unix.go:62:13: undefined: unix.Flock

The problem in that particular dependency appears to be reported in dgraph-io/badger#2035, and the x/sys/unix issue #64669 is related.

@pmur
Copy link
Contributor

pmur commented Sep 4, 2024

@dmitshur are there any other dependencies which do not compile for aix?

I have an attempt to get badger (v4) running on aix, but I need to get approval to post and contribute the patch. I am not sure how long that will take.

@dmitshur
Copy link
Contributor Author

dmitshur commented Sep 4, 2024

Thanks for working on this Paul. From what I can tell this case (cas failing to build for aix/ppc64) is the only known outstanding issue for this port. It's a good idea to check ahead for possible future problems, and I'm not aware of something more at this time.


Here's a quick check I did just now. Looking at a recent build for another fairly similar port openbsd/ppc64 at https://chromium-swarm.appspot.com/task?id=6bd610f803408d10, there seem to be mentions 14 CIPD packages. Out of those, cas is the only one not resolved for aix-ppc64 platform:

$ export PLATFORM=aix-ppc64
cipd instances "infra/experimental/golangbuild/$PLATFORM" >/dev/null
cipd instances "infra/tools/bb/$PLATFORM" >/dev/null
cipd instances "infra/tools/cipd/$PLATFORM" >/dev/null
cipd instances "infra/tools/cloudtail/$PLATFORM" >/dev/null
cipd instances "infra/tools/git/$PLATFORM" >/dev/null
cipd instances "infra/tools/luci-auth/$PLATFORM" >/dev/null
cipd instances "infra/tools/luci/bbagent/$PLATFORM" >/dev/null
cipd instances "infra/tools/luci/cas/$PLATFORM" >/dev/null
cipd instances "infra/tools/luci/docker-credential-luci/$PLATFORM" >/dev/null
cipd instances "infra/tools/luci/git-credential-luci/$PLATFORM" >/dev/null
cipd instances "infra/tools/luci/lucicfg/$PLATFORM" >/dev/null
cipd instances "infra/tools/luci/vpython3/$PLATFORM" >/dev/null
cipd instances "infra/tools/prpc/$PLATFORM" >/dev/null
cipd instances "infra/tools/rdb/$PLATFORM" >/dev/null
Error: no such package: infra/tools/luci/cas/aix-ppc64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-ppc64x Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. new-builder OS-AIX
Projects
Status: In Progress
Development

No branches or pull requests

5 participants