Staying with settings open can crash the entire system

[Kimikz]

So, this is really curious but staying in xlcore settings for some minutes can cause a crash and if you try to relaunch more times all programs just close and the entire session is ununsable.

maybe gamemode implementation is causing this, disabling it with GameModeEnabled=false in launcher.ini and no crashes after almost an hour with settings open.

last-boot.log

[Momorar]

I can confirm that this has happened to me as well. I assumed it was a wayland quirk but attempted replication has shown that it occurs on x11 as well.
Launcher crashes after about 3-4 minutes and when relaunched causes the entire sessions to die. With gamemode disabled, no such crash occurred after tens of minutes of idling in both wayland and x11.

[red-star-fighter]

Happening to me as well. I'm the one who sent Kimikz the last-boot.log file. Just turned off gamemode and not only does the app seem to not crash, this fixed some huge lag happening when in the settings panel.

[EtereosDawn]

the same occurs in fedora 40 worksation

[Kimikz]

yeah, still happening if you stay in wine tab.
it gets a lot of logspam about gamemode till launcher coredumps and eventually everything crash.
journal.log

[Kimikz]

Seems some pull request from @rankynbass fix this issue, maybe #64 ?

[JSEverything]

https://github.com/goatcorp/XIVLauncher.Core/blob/main/src/XIVLauncher.Core/Components/SettingsPage/Tabs/SettingsTabWine.cs#L35
https://github.com/goatcorp/XIVLauncher.Core/blob/main/src/XIVLauncher.Core/Components/SettingsPage/SettingsEntry%7BT%7D.cs#L101
The validity check is performed every draw, which means that if it's enabled, libgamemodeauto is loaded and freed every frame. The purpose of libgamemodeauto is to enable GameMode when it is loaded, and disable it when it's unloaded - this results in GameMode being enabled and disabled 20 times per second. I haven't tested if this causes the crashes, but it's definitely undesired behaviour and seems like a likely culprit.
You can easily test this by editing GameMode's configuration file and setting the options for custom scripts to be run when GameMode starts and ends - with just a notify-send, this results in a spam of notifications.
I use the scripts to for example disable automatic backups and some other things which take about a second, and this makes the launcher update once, maybe twice per second when in the settings view.
I disabled GameMode support in the launcher and run it with gamemoderun from steam until this gets fixed either with #64 or by a smaller patch specifically for this issue.