Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FromB58 requires unused parameter #186

Open
utdrmac opened this issue Apr 4, 2021 · 0 comments
Open

FromB58 requires unused parameter #186

utdrmac opened this issue Apr 4, 2021 · 0 comments

Comments

@utdrmac
Copy link
Contributor

utdrmac commented Apr 4, 2021

func FromBase58(privKey string, kind ECKind) (*Key, error) {

The parameter 'kind` is not used anywhere in the function. Since the kind of curve is determined by inspecting the key itself, this parameter should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant