Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pointcut] Add support for matching by return-type #370

Closed
lisachenko opened this issue Nov 22, 2017 · 2 comments
Closed

[Pointcut] Add support for matching by return-type #370

lisachenko opened this issue Nov 22, 2017 · 2 comments
Labels
Feature Pointcut
Milestone
2.x

Comments

@lisachenko
Copy link
Member

For PHP7 it's allowed to use return typehint for methods and functions. Framework should support this kind of syntax via pointcut expression.

Proposed format is following:

execution(public Example->method(*): string)
execution(Demo\*\Test\**\*(*): bool)

First one for methods and second one for functions.
@lisachenko lisachenko added this to the 2.x milestone Nov 22, 2017
lisachenko added a commit that referenced this issue Nov 22, 2017
@lisachenko
[Pointcut] Implement return-type pointcuts for framework, #370
843a9dc
lisachenko added a commit that referenced this issue Nov 22, 2017
@lisachenko
fixup! [Pointcut] Implement return-type pointcuts for framework, #370
228fa39
lisachenko added a commit that referenced this issue Nov 22, 2017
@lisachenko
[Pointcut] Implement return-type pointcuts for framework, #370 (#371)
56f1bef
lisachenko added a commit that referenced this issue Nov 22, 2017
@lisachenko
Merge remote-tracking branch 'origin/2.x'
36684bd 
* origin/2.x:
  [Pointcut] Implement return-type pointcuts for framework, #370 (#371)
@lisachenko lisachenko mentioned this issue Nov 22, 2017
Open
@lisachenko
Copy link
Member Author

Need to implement matching in PhpStorm plugin too, issue goaop/idea-plugin#17

@lisachenko
Copy link
Member Author

Implemented in #371

@lisachenko lisachenko modified the milestones: 2.x, 3.0.0 Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Pointcut
Milestone
2.x
Development

No branches or pull requests
1 participant
@lisachenko