Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add Chinese Comment Check Workflow to Kratos CI #3422

Open
mo3et opened this issue Sep 13, 2024 · 7 comments · May be fixed by #3426
Open

[Feature] Add Chinese Comment Check Workflow to Kratos CI #3422

mo3et opened this issue Sep 13, 2024 · 7 comments · May be fixed by #3426
Labels
feature

Comments

@mo3et
Copy link
Contributor

mo3et commented Sep 13, 2024

Please see the FAQ in our main README.md before submitting your issue.

Requirements description of the feature

I wrote a workflow for our team to check for Chinese comments in the repository when a Pull Request (PR) is opened. The workflow is currently used in our team repo, and you can find it here.

I would like to this workflows is useful to Kratos's workflows. If so, I will submit a PR to integrate this into the repo.

References

workflows details

workflows effect
@mo3et mo3et added the feature label Sep 13, 2024
@mo3et
Copy link
Contributor Author

mo3et commented Sep 13, 2024

@shenqidebaozi @Windfarer

@kratos-ci-bot
Copy link
Collaborator

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@shenqidebaozi @Windfarer

@shenqidebaozi
Copy link
Member

This situation should not exist in Kratos. I think you can first check if there are any problems in the current warehouse

@mo3et
Copy link
Contributor Author

mo3et commented Sep 14, 2024

There are no issues with the current repo. This workflow is triggered when a contributor creates a PR and checks the submitted code, similar to how Go Test ensures that the submitted content can run properly when a PR is initiated.

The check only runs when a PR is opened. If the contributor's code contains Chinese comments, the CI will report an error.

@mo3et
Copy link
Contributor Author

mo3et commented Sep 14, 2024 •
edited
Loading

If you think this issue is not useful, please close it.

@shenqidebaozi
Copy link
Member

You can submit a PR, add an action, and add a Chinese comment. I would like to see the actual effect

@mo3et
Copy link
Contributor Author

mo3et commented Sep 18, 2024

You can submit a PR, add an action, and add a Chinese comment. I would like to see the actual effect

Fine. I will commit to it later today.

@mo3et mo3et linked a pull request Sep 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implement comment-check in workflows. mo3et/kratos
3 participants
@mo3et @shenqidebaozi @kratos-ci-bot