pulls panic if there is no open pull requests

[quantonganh]

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x14ece93]

goroutine 1 [running]:
code.gitea.io/tea/cmd.runPulls(0xc000106f20, 0xc0001e2000, 0xc000106f20)
	/Users/quanta/go/src/code.gitea.io/tea/cmd/pulls.go:52 +0x363
github.com/urfave/cli.HandleAction(0x155c680, 0x163e5f8, 0xc000106f20, 0x0, 0xc000086ba0)
	/Users/quanta/go/src/github.com/urfave/cli/app.go:502 +0xbe
github.com/urfave/cli.Command.Run(0x161dc87, 0x5, 0x0, 0x0, 0x0, 0x0, 0x0, 0x162e67d, 0x24, 0x0, ...)
	/Users/quanta/go/src/github.com/urfave/cli/command.go:165 +0x420
github.com/urfave/cli.(*App).Run(0xc0001c2380, 0xc0000b6000, 0x4, 0x4, 0x0, 0x0)
	/Users/quanta/go/src/github.com/urfave/cli/app.go:259 +0x6cf
main.main()
	/Users/quanta/go/src/code.gitea.io/tea/main.go:43 +0x264

The reason is: go-gitea/go-sdk#161

[lunny]

Cannot reproduce here.

➜  log git:(master) pwd
/Users/lunny/gopath/src/gitea.com/lunny/log
➜  log git:(master) tea pulls
No pull requests left
➜  log git:(master) tea login
Name	URL	SSHHost
try	https://try.gitea.io	try.gitea.io
gitea	https://gitea.com	gitea.com

[quantonganh]

Look at the error, it happened at this line:

tea/cmd/pulls.go

Line 52 in fb52920

name := pr.Poster.FullName

The main problem is ListPullRequestsOptions does not work. Instead of just list open pull requests, it list all.

In your repo, just

• create a PR
• merged
• tea pulls

to see it show all closed/merged PRs.

[root360-AndreasUlm]

I can reproduce this behaviour.

Printing the resulting addresses of ListRepoPullRequests when the error happens you get:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x8f9aea]
...

The access to the 3rd element then raises the panic.

After adding a 'nil'-check the panic is not raised:

diff --git a/cmd/pulls.go b/cmd/pulls.go
index 7fe7d8b..43e6245 100644
--- a/cmd/pulls.go
+++ b/cmd/pulls.go
@@ -49,6 +49,9 @@ func runPulls(ctx *cli.Context) error {
        }
 
        for _, pr := range prs {
+               if pr == nil {
+                       continue
+               }
                name := pr.Poster.FullName
                if len(name) == 0 {
                        name = pr.Poster.UserName

[lunny]

@root360-AndreasUlm could you send a PR to fix that?

[root360-AndreasUlm]

@lunny I'll send a PR today

[root360-AndreasUlm]

@lunny created PR #18