Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifying local descriptors in documentation #1026

Open
scmartin opened this issue Oct 16, 2022 · 2 comments
Open

Clarifying local descriptors in documentation #1026

scmartin opened this issue Oct 16, 2022 · 2 comments
Labels
task A task to be completed.

Comments

@scmartin
Copy link

Description

The environment.LocalDescriptors documentation doesn't really give a description of what the local descriptors are, how they are calculated, or even a reference that explains what they are. As far as I can tell, one would have to actually look through the source code to find out what this class actually calculates. In a previous version of the documentation there was this example but it is no longer in the 'stable' branch. The documentation for this class should be more explicit about what it calculates and what its properties are.

Motivation and Context

As an end user, it is hard to know whether and how to use classes like this without more information about what they are calculating.

@scmartin scmartin added the task A task to be completed. label Oct 16, 2022
@bdice
Copy link
Member

bdice commented Oct 16, 2022

I agree this documentation (https://freud.readthedocs.io/en/latest/modules/environment.html#freud.environment.LocalDescriptors) can be improved. The publication that developed and used this feature is "Machine learning for crystal identification and discovery" by Matthew Spellings and Sharon C. Glotzer. https://doi.org/10.1002/aic.16157 cc: @klarh

@bdice
Copy link
Member

bdice commented Oct 16, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task A task to be completed.
Projects
None yet
Development

No branches or pull requests

2 participants