Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GET request navigable #10

Open
3 of 4 tasks
rafaelcamargo opened this issue Jun 24, 2018 · 2 comments
Open
3 of 4 tasks

Make GET request navigable #10

rafaelcamargo opened this issue Jun 24, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@rafaelcamargo
Copy link
Member

rafaelcamargo commented Jun 24, 2018

At the moment, get requests respond with all results found. So, requests are taking very long for big amounts of data.
Make pagination enabled by default for any get requests. Suggestion:

  1. List 30 results per page by default
  2. Allow an optional query param called page.
  3. Allow an optional query param called pageSize to change the default value for the number of results per page.
  4. Include a link attribute in response header containing navigation details:
    • e.g.: Link: <https://api.github.com/users?page=2>; rel="next", <https://api.github.com/users?page=50>; rel="last"
@rafaelcamargo
Copy link
Member Author

Other references:

@rafaelcamargo rafaelcamargo changed the title Respond get requests paginated Make GET request navigable Jan 8, 2019
@rafaelcamargo
Copy link
Member Author

Items 1, 2 and 3 resolved on e9ca43f

@rafaelcamargo rafaelcamargo self-assigned this Jan 9, 2019
@rafaelcamargo rafaelcamargo added the enhancement New feature or request label Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant