From af617d0df20f8a07e1f9f43a7005a05917a06311 Mon Sep 17 00:00:00 2001
From: Carlo Beltrame <carlo@beltra.me>
Date: Wed, 28 Sep 2022 17:04:49 +0200
Subject: [PATCH] Add signaling servers to requirements matrix

---
 resources/js/components/feedback/FeedbackEditor.vue           | 4 ++--
 resources/js/components/feedback/InputFeedbackEditorLarge.vue | 4 ----
 .../feedback/requirements_matrix/RequirementsMatrixRow.vue    | 3 ++-
 3 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/resources/js/components/feedback/FeedbackEditor.vue b/resources/js/components/feedback/FeedbackEditor.vue
index 0e1e9f5c..656cc271 100644
--- a/resources/js/components/feedback/FeedbackEditor.vue
+++ b/resources/js/components/feedback/FeedbackEditor.vue
@@ -50,7 +50,6 @@ export default {
     showImpression: { type: Boolean, default: false },
     username: { type: String, default: null },
     collaborationKey: { type: String, default: null },
-    signalingServers: { type: Array, default: null },
   },
   data() {
     const extensions = [
@@ -121,9 +120,10 @@ export default {
     withCollaboration (extensions) {
       const ydoc = new Y.Doc()
       const feedbackKey = 'qualix-feedback-' + this.courseId + '-' + this.collaborationKey.substr(0, 8)
+      const signalingServers = window.Laravel.signalingServers
       const provider = new WebrtcProvider(feedbackKey, ydoc, {
         password: this.collaborationKey.substr(8),
-        ...(this.signalingServers ? { signaling: this.signalingServers } : {})
+        ...(signalingServers ? { signaling: signalingServers } : {}),
       })
       return extensions.concat([
         Collaboration.configure({ document: ydoc }),
diff --git a/resources/js/components/feedback/InputFeedbackEditorLarge.vue b/resources/js/components/feedback/InputFeedbackEditorLarge.vue
index 0edfbbdd..34aee1ae 100644
--- a/resources/js/components/feedback/InputFeedbackEditorLarge.vue
+++ b/resources/js/components/feedback/InputFeedbackEditorLarge.vue
@@ -7,7 +7,6 @@
       :name="name"
       :class="{ 'form-control': !readonly, 'is-invalid': errorMessage || markInvalid }"
       :username="username"
-      :signaling-servers="signalingServers"
       v-model="currentValue"
       v-bind="$attrs"
       @localinput="$emit('localinput')"></feedback-editor>
@@ -35,9 +34,6 @@ export default {
     username () {
       return window.Laravel.username
     },
-    signalingServers () {
-      return window.Laravel.signalingServers
-    },
   }
 }
 </script>
diff --git a/resources/js/components/feedback/requirements_matrix/RequirementsMatrixRow.vue b/resources/js/components/feedback/requirements_matrix/RequirementsMatrixRow.vue
index 3178b74d..379ff608 100644
--- a/resources/js/components/feedback/requirements_matrix/RequirementsMatrixRow.vue
+++ b/resources/js/components/feedback/requirements_matrix/RequirementsMatrixRow.vue
@@ -131,9 +131,10 @@ export default {
       }
       const ydoc = new Y.Doc()
       const feedbackKey = 'qualix-feedback-' + this.feedback.feedback_data.course_id + '-' + this.feedback.collaborationKey.substr(0, 8)
+      const signalingServers = window.Laravel.signalingServers
       new WebrtcProvider(feedbackKey, ydoc, {
         password: this.feedback.collaborationKey.substr(8),
-        ...(this.signalingServers ? { signaling: this.signalingServers } : {})
+        ...(signalingServers ? { signaling: signalingServers } : {}),
       })
       return [Collaboration.configure({ document: ydoc })]
     },