Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cosmology API instead of deprecated cosmology package #124

Open
ntessore opened this issue Aug 2, 2023 · 4 comments · May be fixed by #397
Open

use cosmology API instead of deprecated cosmology package #124

ntessore opened this issue Aug 2, 2023 · 4 comments · May be fixed by #397
Assignees
Labels
api An (incompatible) API change help wanted Extra attention is needed
Milestone

Comments

@ntessore
Copy link
Collaborator

ntessore commented Aug 2, 2023

Switch to use the cosmology API instead of the old, deprecated cosmology package.

There is a work-in-progress CAMB wrapper, which needs to be checked for feature-completeness against all uses of cosmo in GLASS. I don't think we use anything that's not covered by the cosmology API currently (growth functions, power spectra).

Since the cosmology API functions have no dimensionless equivalent to the cosmology package, there is probably some amount of testing needed in e.g. the lensing module.

cc @nstarman

@ntessore ntessore added help wanted Extra attention is needed api An (incompatible) API change labels Aug 2, 2023
@ntessore ntessore added this to the future milestone Aug 2, 2023
@nstarman
Copy link

nstarman commented Aug 3, 2023

How can I help?

@ntessore
Copy link
Collaborator Author

ntessore commented Aug 3, 2023

How can I help?

I think this really only needs some time to sit down and make the changes -- I just wanted to keep you in the loop on this issue.

(And it will probably take longer to write the docs on the cosmology object than to make code changes, there's surprisingly little cosmology use in our library.)

@paddyroddy paddyroddy self-assigned this Nov 7, 2024
paddyroddy added a commit that referenced this issue Nov 7, 2024
Closes #124. Use the improved `cosmology.api` package throughout the
code.
@paddyroddy paddyroddy linked a pull request Nov 7, 2024 that will close this issue
@paddyroddy
Copy link
Member

I've made a start on this in #397. My questions/thoughts:

  1. What is the equivalent of cosmology.Cosmology.dc_inv? We have cosmology.api.StandardCosmology.comoving_distance, but I need the inverse of that
  2. NLA model for intrinsic alignments #21 refers to
  3. What is the equivalent of cosmology.Cosmology.from_camb(pars)? I'm not sure if it's just not ready yet

@paddyroddy
Copy link
Member

Discussed in a meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api An (incompatible) API change help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants