-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
500 Internal server error when visiting link for Pro Git v1 book #1782
Comments
hey @HonkingGoose @derberg, can you share where did you find links to book v1? either way, it seems reasonable to redirect to some page. probably we removed the routing because v1 is really old AFAIK (i see v2 was released around 2014) |
According to the first issue there are links pointing to the v1 version of the book in the GitHub Docs. I will open a PR in the GitHub Docs repo to fix the links. |
I tried making the changes to the GitHub Docs myself, but I'm not allowed to touch the files with the bad links in it. So I'm opening an issue with GitHub Docs, so one of their maintainers can fix it. 😄 |
I'll let you guys decide. Possible fixes:
|
For the record: after #1804 was merged, the link no longer 500s but 404s instead. |
Related: I found this link which doesn’t say anything about the edition: https://git-scm.com/book/en/Git-Tools-Rewriting-History But this works: https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History The second edition. Maybe the first link could try to redirect to |
@LemmingAvalanche good idea! We should automate this by patching in aliases here (both @LemmingAvalanche want to give it a try? |
@dscho Sure thing, I can look at this this evening. I’ll reply later if it turns out that it needs someone more experienced. |
@LemmingAvalanche thank you for clarifying (in a separate, private communication) that you were thinking of redirecting: https://git-scm.com/book/en/Git-Tools-Rewriting-History To: https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History I indeed misunderstood, or maybe it was a Freudian mistake, as the information necessary to reliably map the sections of v1 to v2 is simply not available in the current version of But maybe you can add that mapping, say, as |
URL for broken page
https://git-scm.com/book/en/v1
Problem
The page linked above leads to a 500 Internal Server Error.
Operating system and browser
macOS 13, Firefox 113.0.1
Steps to reproduce
Other details
The Pro Git book is on version 2 now. We should probably redirect to the landing page for the v2 book.
Related issue (filed in the wrong place):
The text was updated successfully, but these errors were encountered: