Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve legend / title and add a second one in dual/split map view #62

Open
robarto opened this issue Apr 23, 2018 · 3 comments
Open

improve legend / title and add a second one in dual/split map view #62

robarto opened this issue Apr 23, 2018 · 3 comments
Assignees
Labels

Comments

@robarto
Copy link

robarto commented Apr 23, 2018

in Dual/Split view both maps need a title and legend.
the window should be a bit smaller, if possible.

@bgunt
Copy link
Collaborator

bgunt commented May 2, 2018

buttons "Themen" and "Klassen" under both maps

@nsteffens nsteffens self-assigned this May 5, 2018
@nsteffens
Copy link
Collaborator

Addressed this in e4e1258 and 33a2b48 but getting the time slider to work in the second map will be kind of difficult without getting too much redundancy in the code. I'd suggest creating a Legend.js class where the time slider and GIF-export behavior might then also move. @felixerdy's opinion would be interesting to this since he implemented these features.

Size adjustments will follow, the question is how urgent this issue is. Should I integrate everything or do you want the basic functionality now on the website.

TL, DR: Legend on second map works, time slider not yet. Size is also still the same. Do you want this already now on the gh-pages branch or do you want to wait until everything is finished?

@felixerdy
Copy link
Collaborator

@nsteffens I would definitely agree on creating a seperate Legend.js class as I already thought about that. Would result in a better code structure and cleaner code.

I think the timeslider should work at least before pushing to gh-pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants