Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove numpy.distutils dependency #88

Open
thomasarsouze opened this issue Jun 19, 2024 · 3 comments
Open

Remove numpy.distutils dependency #88

thomasarsouze opened this issue Jun 19, 2024 · 3 comments

Comments

@thomasarsouze
Copy link
Contributor

forestatrisk currently uses numpy.distutils which is now deprecated

Follow the migration advice to get rid of it, and make forestatrisk work with numpy>=1.23 and python>=3.12.

@ghislainv
Copy link
Owner

Done, see e5e4872.

@thomasarsouze
Copy link
Contributor Author

This was done a bit too fast actually !

We are facing this problem where numpy is now needed for the setup, but is not installed in a clean environment.

Setuptoolofficial solution is to add a pyproject.toml file. This is what is proposed in the PR, although not ideal right now as there is a mix of pyproject.toml and setup.py (and setup.cfg). All this should be merged into a single pyproject.toml later on.

@ghislainv
Copy link
Owner

OK, thanks. In previous versions of forestatrisk we also needed to install numpy previously to forestatrisk. But it is cleaner that way. I let the issue open until we merge pyproject.toml and setup.py.

@ghislainv ghislainv reopened this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants