Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Values of N passed to sub_divide seem wrong #13

Open
ajeb78 opened this issue Sep 7, 2022 · 0 comments
Open

Values of N passed to sub_divide seem wrong #13

ajeb78 opened this issue Sep 7, 2022 · 0 comments

Comments

@ajeb78
Copy link

ajeb78 commented Sep 7, 2022

In bm3d.cpp, lines 272, 304, 307 and 341 seem to do the following:

  • chop the image into pieces with border 2 * nWien
  • reassemble the image based on subimages with borders 2 * nHard
  • chop the image into subimages with borders 2 * nHard
  • reassemble the image based on subimages with borders 2 * nWien

Shouldn't the values of N for chopping the image up and reassembling it be the same? In practice it doesn't matter because nWien and nHard are both defined as the same value, but if one value was changed it seems the result would not be good. I think the parameters on those lines should respectively be 2 * nHard, 2 * nHard, 2 * nWien, 2 * nWien.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant