-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement report_after_job_retries in ActiveJob adapter #2499
Comments
Yes, we should implement |
@sl0thentr0py i gave it a shot in #2500 but ran into several issues:
anyway - i'm closing the pr out but i'll make sure the branch still exists. i think the approach is valid (and it seems to work) but i can't spend anymore time figuring out the tests. |
@modosc thanks a lot! I will reopen the PR and get it into a mergeable state myself. You don't have to do further work on it. |
we are using
sentry-rails
to report errors fromActiveJob
(which is running onsidekiq
). we want the ability to only report on errors when retries are exhausted. there doesn't seem to be a way to do this directly in theActiveJob
integration (sentry-sidekiq
,sentry-delayed_job
, andsentry-resque
all support this configuration option).is it possible to implement this directly in the
ActiveJob
adapter?The text was updated successfully, but these errors were encountered: