Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check request json and form bodies with rack 3 #2448

Open
sl0thentr0py opened this issue Oct 29, 2024 · 1 comment
Open

Check request json and form bodies with rack 3 #2448

sl0thentr0py opened this issue Oct 29, 2024 · 1 comment
Assignees
@sl0thentr0py
Milestone
6.0.0

Comments

@sl0thentr0py
Copy link
Member

sl0thentr0py commented Oct 29, 2024 •
edited
Loading

Rack 3 no longer requires rewindable input so check that we're still working gracefully and add data properly wherever possible.
https://github.com/rack/rack/blob/main/UPGRADE-GUIDE.md

We're relying on this here:

sentry-ruby/sentry-ruby/lib/sentry/interfaces/request.rb

Line 77 in 9446a30

request.body.rewind

@sl0thentr0py sl0thentr0py self-assigned this Oct 29, 2024
@sl0thentr0py
Copy link
Member Author

reference discussion
rack/rack#1972

@sl0thentr0py sl0thentr0py added this to the 6.0.0 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sl0thentr0py sl0thentr0py

Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
2 participants
@sl0thentr0py @stephanie-anderson