Replies: 1 comment 1 reply
-
This problem continued to plague us, we reluctantly forked Numeral so that we could apply a fix
|
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The last release of numeral.js has a major flaw, which is that it cannot parse small numbers
Several fixes have been proposed, such as adamwdraper/Numeral-js#564, but none reviewed.
We tried switching to numbro in #6344 but had to revert it because integers are not rounded properly.
Elastic has a public fork of numeral.js, but it is not ideal since this fork does not have
numeral.options.scalePercentBy100
, which is a feature Redash uses.We should consider creating a fork of numeral.js (as was done with sql-formatter) so that we can apply bug fixes to this library.
Beta Was this translation helpful? Give feedback.
All reactions