MSSQL Limit Issue

[cbbalanquit]

When trying to query MSSQL, I guess it still use LIMIT 1000 as default addition to the query. It was resolved from this issue (issue5528) but not sure why it still persist now even my redash instance is the updated one right now

[justinclift]

Yeah, I've seen this happen with a customer's production instance as well, several months ago.

The solution in that case was to patch the source, so that the 1000 limit row wasn't applied for any data source. That's fine for this particular customer, but obviously isn't what's needed for the "full and proper solution" for everyone.

[cbbalanquit]

I see. What part in the codebase should I modify to path this 1000 limit? not really familiar yet in where to look

[cbbalanquit]

I think I saw it. changed the default to false

[justinclift]

Screenshot seems busted?

[cbbalanquit]

I reupload it

[justinclift]

Cool. When I did it, I just ripped out the Python backend code that implemented the query limit.

But it looks like your approach might work too.

Does it seem to? 😄

[cbbalanquit]

Yes it worked too, luckily. I can already query without error in limits..but not sure tho how can i adjust this for mssql only so once i deployed in prod

[justinclift]

Cool. Good that it worked.

But yeah, I'm not sure how to do the "proper" implementation either (yet).