Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative font sizes for h2, h3 #15

Open
atomsmith opened this issue Jun 5, 2016 · 0 comments
Open

Negative font sizes for h2, h3 #15

atomsmith opened this issue Jun 5, 2016 · 0 comments

Comments

@atomsmith
Copy link

When using Chrome Developer Tools, I noticed that h2 and h3 elements have invalid font sizes. These originate from the following declarations in configuration/nucleus/_typography.scss:

$h2-font-size: $core-font-size - 1.60 !default;
$h3-font-size: $core-font-size - 1.50 !default;

Since $core-font-size is 1rem, the compiled CSS is:

h2 {
font-size: -0.6rem; }

h3 {
font-size: -0.5rem; }

Should those subtractions be additions instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant