-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
About the compression mechanism #400
Comments
Despite the code has been added since 2016 e980077 , the (current) doc never says that Line 11 in 144ebca
("compressed directory" is weird, probably means "compressed file.") I think another solution is to clarify only ".{format}.zip", ".{formart}.tar", ".{format}.tar.gz", ".csv.gz" (via @schochastics Thoughts? |
If we properly document what is supported and what not we can take the "not-support-xz" road and use R.utils to fix the remaining compression |
Cool. Then let's do it.
|
As there are many bugs (#395 #396 #399) after really testing this bunch of code (#354)
Other than the issues of compression detection, this
rio/R/compression.R
Lines 25 to 44 in 2fb1373
is super not robust (e.g. it won't return a file and
o
is still 0). Instead of using this, the plan is to use the battle-testedR.utils
compression. Well, evendata.table
is using it and that's the reason for introducingR.utils
in the first place #362 .https://github.com/Rdatatable/data.table/blob/2487c61656335764980e478c323f7e6ce4e6d4ca/R/fread.R#L123
But the problem is that
R.utils
doesn't supportxz
. (But I think it should be okay to cutxz
. No one complains aboutxz
not functioning, although it is not functioning for so many years.)The text was updated successfully, but these errors were encountered: