Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Review - 25 Feb 2019 - SHA 7bbbe678eda #4

Open
glennsarti opened this issue Feb 25, 2019 · 0 comments
Open

Code Review - 25 Feb 2019 - SHA 7bbbe678eda #4

glennsarti opened this issue Feb 25, 2019 · 0 comments
Labels
Improvement
Milestone
0.1.0

Comments

@glennsarti
Copy link

Missing export of the New-PoshBotGitterBackend function ?

https://github.com/gep13/PoshBot.Gitter.Backend/blob/7bbbe678eda308c3f47f9549961e560ee2f27221/PoshBot.Gitter.Backend/PoshBot.Gitter.Backend.psd1#L72

RoomID seems to be a required property but it's not checked at Source Code

Unable to verify SendMessage visually, but it looks ok. Best tested manually on a real gitter server.

Everything else looks fine. It's not using a WebSocket. Looks like good 'ol fashioned Long Poll.
@gep13 gep13 added this to the 0.1.0 milestone Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
2 participants
@gep13 @glennsarti