#10736: Interactive legend for TOC layers [WFS Layer part] #10748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…art] Description: - handle the functionality of interactive legend for WFS layers - create geostyler converter to cql - handle saving the legend filter of layer into layerFilter object in saving - handle showing incompatible message in case change into filtered style - add unit tests - add translations
allyoucanmap
requested changes
Jan 14, 2025
There was a problem hiding this comment.
Please take a look to the inline comments.
Found an issue while testing locally:
- When experimentalInteractiveLegend config is false in the localConfig the interactive legend is active by default and the settings are showing the Legend title without content
legend-issue-01.mp4
web/client/components/catalog/editor/AdvancedSettings/__tests__/CommonAdvancedSettings-test.js
Show resolved
Hide resolved
…art] (resolve reviews) - fix issue of activating interactive legend even if experimentalInteractiveLegend = false in localConfig - remove serverType check for wfs interactivity legend display - replace owner prop with interactive prop for wms and wfs - handle not calling legend filter handler in case not activate the interactivity or no rule to apply - add double check for geostyler if it is a direct array or has body in converter file - reset miscSettings in CommonAdvancedSettings test file in afterEach - add tranlations
allyoucanmap
approved these changes
Jan 27, 2025
|
@ElenaGallo please test this enhancement in DEV, please also check if the interactive legend still work as expected for WMS layer, thanks |
4 tasks
|
@mahmoudadel54 a note after my tests: 1_ By disabling the interactive legend, the enable/disable filter legend icon remains visible in the toc (same from dashboard and geosotry) legend1.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes handling the functionality of interactive legend for WFS layers for mapViewer/dashboards/geostories. User can enable interactive legend from catalog or layer settings. A geostyler converter is created in this PR to handle converting from geostyler to cql.
If legend filter is applied, then user makes any change to the style --> a warning should appear when the user comes back to the TOC after having changed the style.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10736
What is the current behavior?
#10736
What is the new behavior?
If user enables interactive legend for WFS layer via catalog or layer settings, user can filter by legend.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
It is experimental feature