Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Context - MS Landing Page #4460

Closed
tdipisa opened this issue Nov 7, 2019 · 8 comments
Closed

Application Context - MS Landing Page #4460

tdipisa opened this issue Nov 7, 2019 · 8 comments

Comments

@tdipisa
Copy link
Member

tdipisa commented Nov 7, 2019

Description

Some updates are needed in MS home page to manage context maps.

1 - Possibility to filter maps by context to show resources belonging to a specific context. It should be possible to enable/disable the context filter by configuration file (localConfig).

Note: This filter tool could be improved in the future to host additional filtering capabilities (like data, keywords etc).

The mockup for this is available here:

image

2 - Possibility to create maps starting from a created application context instead of the default one: clicking on "New Map" button a modal opens to show the list of app context the user can access to. If one of them is clicked the viewer opens and the user can create the map as usual.

3- If you have not access to the context you now see the full screen message that explain that the resource is not accessible. You have to add the possibility (this functionality can be turned off via configuration) to redirect the user to the default viewer, sending a warning message:
The context of this map is not accessible or has been deleted, you have been redirected to the default viewer

Other useful information (optional):

Generally speaking Users that are able to access an application context defined in MS, should be able to create maps from it, this means maps with a final URL like the one below:

https://dev.mapstore2.geo-solutions.it/mapstore/#/context/{ContextName}/{MapId}

@vlt1
Copy link
Contributor

vlt1 commented Feb 21, 2020

@tdipisa When context is deleted, do we need to find maps that belong to this context and delete them as well?

@offtherailz
Copy link
Member

offtherailz commented Feb 24, 2020

@vlt1 I opened an issue about this on geostore,

In order to batch update all the resources.
see this
We can move the task of "updating maps when context has been deleted" in this issue: #4927

@offtherailz
Copy link
Member

@vlt1 for the moment the only thing you need to add to this task is, in case of missing or not accessible context, redirect to the main viewer to see the map. A warnig message will notify the user that the context is not accessible, so he has been redirected to the default viewer. This behaviour should be turned on or off via configuration.

@ElenaGallo
Copy link
Contributor

@tdipisa @vlt1

1_When log out from MS, the filter should be disabled and the pop up closed
filtercontext

How to reproduce

  • open MapStore
  • Login as admin
  • filter a context from search bar
  • log out

Current Result
The filter still enable and the pop up is open

2_ The scroll bar is slightly out of modal
scroll bar not centered

3_You are always redirected to the default viewer

How to reproduce

  • open mapstore
  • login as admin
  • click on new map (existing context)
  • search 4460_context
  • Click on it

Current Result
you have been redirected to the default viewer

@tdipisa
Copy link
Member Author

tdipisa commented Mar 13, 2020

1_When log out from MS, the filter should be disabled and the pop up closed

@ElenaGallo, it is questionable. If you logout the filter is anyway updated, @offtherailz what do you think?

2_ The scroll bar is slightly out of modal

@ElenaGallo you are right, @vlt1 please provide a fix for this, thank you.

3_You are always redirected to the default viewer

@ElenaGallo you are right, but I suppose that the curent logic wants to ensure the possibility to save the new map even if the plugin Save is not present in the context: @offtherailz, @vlt1 can you confirm this or explain which is the logic applied there? @offtherailz if my understanding is confirmed, probably we should discuss this a little bit.

@offtherailz
Copy link
Member

offtherailz commented Mar 13, 2020

1--> If the filter is updated with the resources the user has access to, it may stay. Anyway to keep things easy to maintain, I like also resetting the filter on login/logout (it is a trivial task, as far as I know).

3 --> You're right @tdipisa .
Yes, I had the same effect when I tried the first time. It is misleading, even it is the only way to do it, now. We could improve this, but we have to think to an alternative solution.

@offtherailz
Copy link
Member

offtherailz commented Mar 13, 2020

Ok.
Please @vlt1 can you do these tasks:

  • reset the filter when login/logout (point 1)
  • fix the issue with the scroll bar (point 2)

@tdipisa will process point 3. Thank you all

@vlt1
Copy link
Contributor

vlt1 commented Mar 13, 2020

@offtherailz I've tested with firefox and chromium, the issue with the scroll bar is not present on my machine :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants