Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prodigal training files are moved in Makefile but not in config files #279

Open
samuell opened this issue Mar 26, 2024 · 1 comment
Open
Assignees
Labels
bug Something isn't working low Low priority

Comments

@samuell
Copy link
Contributor

samuell commented Mar 26, 2024

Just noted (after a Makefile update and trying to run an MRSA analysis) that the prodigal training files are moved into assets/prodigal_training_files, which makes sense and looks good.

But in the config files, the paths still point to cgmlst/<species>/alleles_rereffed/<Species>.trn (and cgmlst/<species>/ecoli_INNUENDO_wgMLST/<Species>.trn for E.coli).

I'm a little confused about how the CI pipeline is still working though 🤔

@samuell samuell added the bug Something isn't working label Mar 26, 2024
@samuell
Copy link
Contributor Author

samuell commented Mar 26, 2024

Well, turns out both the old and the new paths are used in the Makefile:

$ grep Staphylococcus_aureus.trn Makefile 
staphylococcus_aureus_download_prodigal_training_file: $(PRODIGAL_TRAINING_DIR)/Staphylococcus_aureus.trn
$(PRODIGAL_TRAINING_DIR)/Staphylococcus_aureus.trn:
        && wget https://raw.githubusercontent.com/B-UMMI/chewBBACA/master/CHEWBBACA/prodigal_training_files/Staphylococcus_aureus.trn \
staphylococcus_aureus_prep_cgmlst_schema: | $(SAUR_CGMLST_DIR)/alleles_rereffed/Staphylococcus_aureus.trn
$(SAUR_CGMLST_DIR)/alleles_rereffed/Staphylococcus_aureus.trn: $(SAUR_CGMLST_DIR)/alleles_rereffed
                --ptf $(PRODIGAL_TRAINING_DIR)/Staphylococcus_aureus.trn |& tee -a $(INSTALL_LOG)

So, both $(PRODIGAL_TRAINING_DIR) and $(SAUR_CGMLST_DIR)/alleles_rereffed is used, for S. Aureus, for example.

Maybe it is fine? It just looked a little off at a quick glance ... ?

@ryanjameskennedy ryanjameskennedy added the low Low priority label Jan 9, 2025
@ryanjameskennedy ryanjameskennedy added this to the General pipeline milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low Low priority
Projects
None yet
Development

No branches or pull requests

2 participants