From 0ada0b459d4a04ff3eef940cc87a502861e7b8f3 Mon Sep 17 00:00:00 2001
From: Johannes Marbach <johannes.marbach@gematik.de>
Date: Thu, 16 May 2024 13:19:50 +0200
Subject: [PATCH] Remove and assert absence of puml output file names

---
 .github/workflows/lint.yml                    | 78 ++++++++++++-------
 .../TI-M_ePA/TI-Messenger_OIDC_login_fdv.puml |  2 +-
 ...I-Messenger_OIDC_login_fdv_simplified.puml |  2 +-
 .../Ressourcen/UC_10063_Seq.puml              |  2 +-
 .../Ressourcen/UC_10235_Seq.puml              |  2 +-
 .../Ressourcen/UC_Directory_search_Seq.puml   |  2 +-
 .../Ressourcen/UC_tim_specific_comm.puml      |  2 +-
 7 files changed, 58 insertions(+), 32 deletions(-)

diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index c971aeab..5864dcd1 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -8,32 +8,6 @@ on:
   workflow_dispatch:
 
 jobs:
-  drawio:
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Check out repository
-        uses: actions/checkout@v4
-
-      - name: Verify number of diagrams
-        run: |
-          function err {
-            >&2 echo -e "\033[0;31m$@\033[0m"
-          }
-
-          rc=0
-
-          while read -r file; do
-            echo "Checking $file"
-
-            if [[ $(grep "<diag" "$file" | wc -l) -ne 1 ]]; then
-              err "$file does not contain exactly one diagram"
-              rc=1
-            fi
-          done < <(find . -name "*.drawio")
-
-          exit $rc
-
   asciidoc:
     runs-on: ubuntu-latest
 
@@ -85,3 +59,55 @@ jobs:
           done < <(find . -type f -name "*.adoc")
 
           exit $rc
+
+  drawio:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Check out repository
+        uses: actions/checkout@v4
+
+      - name: Verify number of diagrams
+        run: |
+          function err {
+            >&2 echo -e "\033[0;31m$@\033[0m"
+          }
+
+          rc=0
+
+          while read -r file; do
+            echo "Checking $file"
+
+            if [[ $(grep "<diag" "$file" | wc -l) -ne 1 ]]; then
+              err "$file does not contain exactly one diagram"
+              rc=1
+            fi
+          done < <(find . -name "*.drawio")
+
+          exit $rc
+
+  puml:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Check out repository
+        uses: actions/checkout@v4
+
+      - name: Verify absence of output file names
+        run: |
+          function err {
+            >&2 echo -e "\033[0;31m$@\033[0m"
+          }
+
+          rc=0
+
+          while read -r file; do
+            echo "Checking $file"
+
+            if grep -qE "^@startuml\s+." "$file"; then
+              err "$file contains illegal output name in @startuml"
+              rc=1
+            fi
+          done < <(find . -name "*.puml")
+
+          exit $rc
\ No newline at end of file
diff --git a/src/plantuml/TI-M_ePA/TI-Messenger_OIDC_login_fdv.puml b/src/plantuml/TI-M_ePA/TI-Messenger_OIDC_login_fdv.puml
index 497b767c..efd36388 100644
--- a/src/plantuml/TI-M_ePA/TI-Messenger_OIDC_login_fdv.puml
+++ b/src/plantuml/TI-M_ePA/TI-Messenger_OIDC_login_fdv.puml
@@ -1,4 +1,4 @@
-@startuml "TI-Messenger_OIDC_Login"
+@startuml
 skinparam sequenceMessageAlign direction
 skinparam WrapWidth 300
 skinparam minClassWidth 150
diff --git a/src/plantuml/TI-M_ePA/TI-Messenger_OIDC_login_fdv_simplified.puml b/src/plantuml/TI-M_ePA/TI-Messenger_OIDC_login_fdv_simplified.puml
index 4fdf4aa3..c8cf3d95 100644
--- a/src/plantuml/TI-M_ePA/TI-Messenger_OIDC_login_fdv_simplified.puml
+++ b/src/plantuml/TI-M_ePA/TI-Messenger_OIDC_login_fdv_simplified.puml
@@ -1,4 +1,4 @@
-@startuml "TI-Messenger_OIDC_Login_simplified"
+@startuml
 skinparam sequenceMessageAlign direction
 skinparam WrapWidth 300
 skinparam BoxPadding 1
diff --git a/src/plantuml/TI-Messenger-Dienst/Ressourcen/UC_10063_Seq.puml b/src/plantuml/TI-Messenger-Dienst/Ressourcen/UC_10063_Seq.puml
index 207c0c81..6fc30803 100644
--- a/src/plantuml/TI-Messenger-Dienst/Ressourcen/UC_10063_Seq.puml
+++ b/src/plantuml/TI-Messenger-Dienst/Ressourcen/UC_10063_Seq.puml
@@ -2,7 +2,7 @@
 # UC - 10063
 # Name: Austausch von Events zwischen Akteuren innerhalb einer Organisation
 '/
-@startuml 
+@startuml
 skinparam sequenceMessageAlign direction
 skinparam minClassWidth 200
 skinparam BoxPadding 1
diff --git a/src/plantuml/TI-Messenger-Dienst/Ressourcen/UC_10235_Seq.puml b/src/plantuml/TI-Messenger-Dienst/Ressourcen/UC_10235_Seq.puml
index 759e7cf8..2e74d18c 100644
--- a/src/plantuml/TI-Messenger-Dienst/Ressourcen/UC_10235_Seq.puml
+++ b/src/plantuml/TI-Messenger-Dienst/Ressourcen/UC_10235_Seq.puml
@@ -1,4 +1,4 @@
-@startuml "Einträge im VZD-FHIR-Directory suchen"
+@startuml
 skinparam sequenceMessageAlign direction
 skinparam minClassWidth 200
 skinparam BoxPadding 1
diff --git a/src/plantuml/TI-Messenger-Dienst/Ressourcen/UC_Directory_search_Seq.puml b/src/plantuml/TI-Messenger-Dienst/Ressourcen/UC_Directory_search_Seq.puml
index e0282068..a9a7cf2b 100644
--- a/src/plantuml/TI-Messenger-Dienst/Ressourcen/UC_Directory_search_Seq.puml
+++ b/src/plantuml/TI-Messenger-Dienst/Ressourcen/UC_Directory_search_Seq.puml
@@ -1,4 +1,4 @@
-@startuml "Einträge im VZD-FHIR-Directory suchen"
+@startuml
 skinparam sequenceMessageAlign direction
 skinparam minClassWidth 200
 skinparam BoxPadding 1
diff --git a/src/plantuml/TI-Messenger-Dienst/Ressourcen/UC_tim_specific_comm.puml b/src/plantuml/TI-Messenger-Dienst/Ressourcen/UC_tim_specific_comm.puml
index daf50b67..85a13fa0 100644
--- a/src/plantuml/TI-Messenger-Dienst/Ressourcen/UC_tim_specific_comm.puml
+++ b/src/plantuml/TI-Messenger-Dienst/Ressourcen/UC_tim_specific_comm.puml
@@ -1,4 +1,4 @@
-@startuml "TI-M spezifische Kommunikation"
+@startuml
 !pragma layout smetana
 skinparam actorStyle awesome
 left to right direction