Skip to content
This repository has been archived by the owner on Apr 16, 2024. It is now read-only.

🐛 BUG: Non-deterministic DownloadController unit test failure #988

Open
2 tasks
torss opened this issue Nov 6, 2018 · 0 comments
Open
2 tasks

🐛 BUG: Non-deterministic DownloadController unit test failure #988

torss opened this issue Nov 6, 2018 · 0 comments
Labels
api All Backend related Issues bug This Issue describes a unwanted behavior

Comments

@torss
Copy link
Collaborator

torss commented Nov 6, 2018

An apparent unit test bug manifested itself here in a Travis CI run:

1) DownloadFile
       POST /api/download/pdf/individual
         should pass:
     Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/travis/build/geli-lms/geli/api/build/test/integration/download.js)

Re-running the tests (tested once locally and once in Travis CI) didn't reproduce this failure, so apparently this unit test bug is non-deterministic. Because of this it may be necessary to manually audit the unit test(s) and/or controller route code to find the problem.

Acceptance criteria:

  • Find the cause of this issue.
    (Also check whether it might affect other DownloadController unit tests / routes.)
  • Fix it.

Additional info:

This might be a duplicate of #913?

@torss torss added bug This Issue describes a unwanted behavior api All Backend related Issues labels Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api All Backend related Issues bug This Issue describes a unwanted behavior
Projects
None yet
Development

No branches or pull requests

1 participant