Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System test user jars in ingest, compaction and query #4134

Closed
patchwork01 opened this issue Jan 24, 2025 · 0 comments · Fixed by #4163
Closed

System test user jars in ingest, compaction and query #4134

patchwork01 opened this issue Jan 24, 2025 · 0 comments · Fixed by #4163
Assignees
Milestone

Comments

@patchwork01
Copy link
Collaborator

patchwork01 commented Jan 24, 2025

Background

Follows on from:

Description

We'd like a system test that uses an iterator held in a user jar during ingest, query and compaction.

Analysis

We can upload the user jar as part of the deployment of a test Sleeper instance in DeployedSleeperInstances.firstConnectInstance, and set it in the user jars property at that point.

We could add user jars as an option in SystemTestInstanceConfiguration, so that they're only configured against an instance that will use it.

The actual upload of the user jar will be done already as long as it's in the local jars directory, as SyncJars just makes the jars bucket match the jars directory.

Ingest and compaction both apply the table iterator, while query applies both the table iterator, and an iterator specified in the query. We can test all of these cases.

@patchwork01 patchwork01 modified the milestones: 0.28.0, 0.29.0 Jan 24, 2025
@patchwork01 patchwork01 changed the title System test iterators in compaction and query System test iterators in ingest, compaction and query Jan 27, 2025
@patchwork01 patchwork01 changed the title System test iterators in ingest, compaction and query System test user jars in ingest, compaction and query Jan 28, 2025
@patchwork01 patchwork01 self-assigned this Jan 28, 2025
@patchwork01 patchwork01 changed the title System test user jars in ingest, compaction and query System test user jars in compaction and query Jan 28, 2025
@patchwork01 patchwork01 changed the title System test user jars in compaction and query System test user jars in ingest, compaction and query Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant