Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gaffer gremlin should have tinkerpop v3 serialiser in by default #359

Closed
tb06904 opened this issue May 16, 2024 · 0 comments · Fixed by #360
Closed

Gaffer gremlin should have tinkerpop v3 serialiser in by default #359

tb06904 opened this issue May 16, 2024 · 0 comments · Fixed by #360
Labels
bug Confirmed or suspected bug
Milestone
v2.2.2

Comments

@tb06904
Copy link
Member

tb06904 commented May 16, 2024

The current gremlin server yaml file is missing the serialiser for v3 tinkerpop JSON by default this should be added so modern tooling can talk to it rather than using the v1 fallback.

Basically just needs following adding to the yaml:

- { className: org.apache.tinkerpop.gremlin.util.ser.GraphSONMessageSerializerV3, config: { ioRegistries: [org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerIoRegistryV3] }}
@tb06904 tb06904 added the bug Confirmed or suspected bug label May 16, 2024
@cn337131 cn337131 linked a pull request May 16, 2024 that will close this issue
Gh-359: Add Tinkerpop serializer #360
Merged
@github-actions github-actions bot mentioned this issue May 16, 2024
Merged
GCHQDeveloper314 added a commit that referenced this issue May 17, 2024
@GCHQDeveloper314
Merge branch 'develop' into gh-359-gaffer-gremlin-should-have-tinkerp…
1f8626b 
…op-v3-serialiser-in-by-default
@GCHQDeveloper314 GCHQDeveloper314 added this to the v2.3.0 milestone May 17, 2024
GCHQDeveloper314 pushed a commit that referenced this issue May 20, 2024
@cn337131
Gh-359: Add Tinkerpop serializer (#360)
c3b06f2 
add serializer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed or suspected bug
Projects
None yet
Milestone
v2.2.2
Development

Successfully merging a pull request may close this issue.

Gh-359: Add Tinkerpop serializer gchq/gaffer-docker
2 participants
@GCHQDeveloper314 @tb06904