Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t.Int: use Number.isSafeInteger instead of Number.isInteger #702

Open
lukasz-jagielski-bolt opened this issue Sep 28, 2023 · 0 comments
Open

Comments

@lukasz-jagielski-bolt
Copy link

🚀 Feature request

Current Behavior

t.Int uses Number.isInteger which is unsafe to use outside of range <Number.MIN_SAFE_INTEGER, Number.MAX_SAFE_INTEGER> (non-integer inputs will return false positive). https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isInteger

Desired Behavior

To be safe t.Int could fail validation of Numbers outside of range <Number.MIN_SAFE_INTEGER, Number.MAX_SAFE_INTEGER>

Suggested Solution

Use Number.isSafeInteger instead of Number.isInteger

Who does this impact? Who is this for?

Everyone using t.Int

Describe alternatives you've considered

Provide a secondary type t.SafeInt?

Additional context

Thanks for a great library, this is something that perhaps could make using it safer :)

Your environment

Software Version(s)
io-ts 2.2.16
fp-ts 2.10.5
TypeScript 4.7.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant