Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

Rebase support #10

Open
gavv opened this issue Oct 7, 2021 · 0 comments
Open

Rebase support #10

gavv opened this issue Oct 7, 2021 · 0 comments
Labels
feature New feature or request good first issue Good for newcomers help wanted Contributions are welcome

Comments

@gavv
Copy link
Owner

gavv commented Oct 7, 2021

Currently this action uploads files to a repo by adding a new commit.

This is not always needed, because often we don't need to keep intermediate versions of artifacts from the same PR in history; we always need only the last one.

To achieve this, we can add an option ti support uploading via rebase + force push:

  • clone repo
  • remove all our older commits that upload the same artifact
  • add a new commit on top that adds the artifact
  • force-push to the repo

To avoid race conditions with other instances of the action that might also try to force-push, we should use --force-with-lease option. See manual page for git-push for details.

@gavv gavv added help wanted Contributions are welcome good first issue Good for newcomers labels Oct 7, 2021
@gavv gavv mentioned this issue Oct 7, 2021
@gavv gavv added the feature New feature or request label Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request good first issue Good for newcomers help wanted Contributions are welcome
Projects
None yet
Development

No branches or pull requests

1 participant