font-decoding.js wrong arguments, pass 1 argument which is a valid index in the array

[blairjanis]

When using the sample for extracting text, I kept getting an error in the font-decoding.js code. The issue is on line 76:

map[j] = besToUnicodes(unicodeArray.queryObject(j).toBytesArray());

queryObject(j) throws an error because j is a number representing the items position in the map that is getting created during the parsing but the unicodeArray is usually just a length of 1 where my pdfs are hitting this code. So using j tries to pull an index in the array that doesn't exist.

I was able to fix the issue by changing things thusly:

if(operands[i+2].getType() === hummus.ePDFObjectArray) {
    var unicodeArray = operands[i+2].toPDFArray();
    // specific codes
    for(var j = startCode;j<=endCode;++j) {
        map[j] = besToUnicodes(unicodeArray.queryObject(j).toBytesArray());
    }
}

becomes ...

if(operands[i+2].getType() === hummus.ePDFObjectArray) {
    var unicodeArray = operands[i+2].toPDFArray();
    // specific codes
    var index = 0;
    for(var j = startCode;j<=endCode;++j) {
        map[j] = besToUnicodes(unicodeArray.queryObject(index).toBytesArray());
        index++;
    }
}