Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds option to run FragPipe job with higher memory #770

Closed

Conversation

reid-wagner
Copy link
Contributor

The Galaxy administrator may use this variable to run the job with increased resources.

@@ -71,6 +71,9 @@
<!-- Only generate a workflow, don't run FragPipe -->
<param name="workflow_only" type="boolean" truevalue="yes" falsevalue="no" checked="false" label="Only generate the workflow output"/>

<!-- Galaxy admins may utilize this variable to for jobs requiring higher memory -->
<param name="high_memory" type="boolean" checked="false" label="High memory job" help="This option is made available for Galaxy administrators to allocate more resources to FragPipe when selected. It may not be used by all systems - please contact your adminstrator to learn if your Galaxy instance does."/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed some discussion I guess. How should a user know that? What is the use-case here?
Is the TPV rule not working?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TPV rule checks for this parameter. So this parameter will not be used by all installations, which I noted to the user in the help section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure there's an exact precedent for this. I see that hifiasm also passes the parameter it uses for TPV to the program's command-line args, whereas this parameter is only used by TPV. But I thought this was a straightforward way to allow a user to request more memory, if the request can be fulfilled.

@bgruening
Copy link
Member

I guess this can be cloned?

@reid-wagner
Copy link
Contributor Author

I guess this can be cloned?

Yes, thanks for the reminder. To document the discussion here - we are leaving the memory configuration choices to the admins alone, who can utilize input file sizes and other tool-related config. In the meantime, on usegalaxy.eu we simply increased the memory for all FragPipe jobs and it seems to be working well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants