Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear what to do with query parameters #152

Open
fbacall opened this issue Sep 15, 2020 · 3 comments
Open

Unclear what to do with query parameters #152

fbacall opened this issue Sep 15, 2020 · 3 comments

Comments

@fbacall
Copy link

fbacall commented Sep 15, 2020

The /tools endpoint allows the user to pass various query parameters to filter by: https://ga4gh.github.io/tool-registry-service-schemas/preview/2.0.0/docs/html5/index.html#_parameters

but for description, for example, it just says "The description of the tool.". What should the implementing service do with this? An exact string match? Partial?

(Also, is this the right repo to raise issues with the validator?)

┆Issue is synchronized with this Jira Story
┆containerName: GA4GH tool-registry-service
┆Issue Number: TRS-39

@garyluu
Copy link
Contributor

garyluu commented Sep 15, 2020

You can create valdiator issues at: https://github.com/ga4gh/tool-registry-validator/issues

@coverbeck
Copy link
Contributor

but for description, for example, it just says "The description of the tool.". What should the implementing service do with this? An exact string match? Partial?

FWIW, the Dockstore implementation does a partial match. But it seems like it should be formally defined in the spec, unless the intent was to give flexibility to the implementers.

@uniqueg
Copy link
Collaborator

uniqueg commented Sep 19, 2020

Until this is clearly specified, we are implementing an exact match for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants