Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add crossfade #1488

Open
NotSoNitro opened this issue Nov 18, 2024 · 2 comments
Open

[Feature Request] Add crossfade #1488

NotSoNitro opened this issue Nov 18, 2024 · 2 comments
Labels

Comments

@NotSoNitro
Copy link

NotSoNitro commented Nov 18, 2024

Use Cases

Cross-fading is a nice feature to have as it allows seamless transitioning into another track. It adds a nice listening experience, I believe it would be a nice feature to have as well.

Proposal

Add a toggle like in app to turn off and on crossfade and when turned on it shows a new option to show how much to crossfade by, max 12 seconds and defaults to 5 seconds. Maybe a bit much but would give us more options to choose when cross-fading!

References

@Zvonimir-FUTO Zvonimir-FUTO changed the title Adding crossfade to spotify plugin [Feature Request] Add crossfade Nov 18, 2024
@Zvonimir-FUTO
Copy link
Collaborator

@NotSoNitro apologies for hijacking your ticket but the way Grayjay is, it would make more sense to implement this in core so all plugins can use it. Hope you don't mind :)

@NotSoNitro
Copy link
Author

NotSoNitro commented Nov 18, 2024

@Zvonimir-FUTO Sure! I was thinking more of the music side since on Spotify I use the Crossfade as it gives a nice seamless Crossfade. If it does get added to the core then for plugins with videos (for example YouTube) then it would be better to work if it's on audio only as crossfading with videos might cause issues possibly (?) plus it would probably be distracting when watching videos specifically, would be nice for both music and podcasts though! But it's up to how you guys want to implement it, if there's a better way you can make it work then that's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants