Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI "data and type mismatch found" #182

Open
Thorium opened this issue May 12, 2021 · 6 comments
Open

OpenAPI "data and type mismatch found" #182

Thorium opened this issue May 12, 2021 · 6 comments

Comments

@Thorium
Copy link
Member

Thorium commented May 12, 2021

I'm trying to read this schema:
https://developer.experian.com/system/files/2020-12/credit-profile-product-apis-v-openapi3.2.0.45.yaml

I'm getting a lot of "Data and type mismatch found" errors.
And indeed, it seems that the types vary:
permissiblePurpose/type seems to be sometimes 08 and sometimes '08' and sometimes just ''.

Is the schema totally un-usable wtih OpenApiProvider, or is it still possible to use it by forcing the types manually (with some static parameter maybe?), so that the type is "either string or int" or "force to string"?

FSharp.Data is usually creating IntOrString and then I have to manually deal with both cases, but at least the type-provider is still usable.

I don't care the solution details, I do care a workaround to get this ~10k lines of type-definitions into use easily.

@sergey-tihon
Copy link
Member

OpenApiProvider is build on top of Microsoft.OpenApi.Readers
we use "official" parser and report back error if parser is not happy about schema
https://github.com/fsprojects/SwaggerProvider/blob/net5/src/SwaggerProvider.DesignTime/Provider.OpenApiClient.fs#L64-L69

There is no auto-recovery option for now.
You may try to comment lines where we fail in case of errors in schema or even add static parameter to not fail in this case.
But I think that everything may just go wrong if we ignore schema errors.

@Thorium
Copy link
Member Author

Thorium commented May 13, 2021

Thanks for the response, I'll ask the question from their project.

@Thorium
Copy link
Member Author

Thorium commented May 17, 2021

They were fast, they fixed that, and the fix is already merged to their "vnext" branch.

Edit: the fix was just to comment that rule out.

@sergey-tihon
Copy link
Member

Let me know when they release on NuGet and I'll release updated provider

@purkhusid
Copy link

A 1.3.0-preview has been released and is available here https://www.nuget.org/packages/Microsoft.OpenApi.Readers/

@sergey-tihon
Copy link
Member

I've updated all dependencies and released v1.0.0-beta4 with Microsoft.OpenApi.Readers v1.3.0-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants