You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// when we release the GitHub module, this will be replaced with GitHub.createPullRequest API
about changing to GitHub.createPullRequest in the future, and thought I'd try making that change to simplify things.
Howevver, when I went to do it I noticed that the return type of createPullRequest is Async<Async<PullRequest>>, which meant that the sample didn't quite work as the result of calling Async.RunSynchronously is still Async<PullRequest>.
When looking through build.fsx, I noticed the comment at
FAKE/build.fsx
Line 1055 in fac7295
GitHub.createPullRequest
in the future, and thought I'd try making that change to simplify things.Howevver, when I went to do it I noticed that the return type of
createPullRequest
isAsync<Async<PullRequest>>
, which meant that the sample didn't quite work as the result of callingAsync.RunSynchronously
is stillAsync<PullRequest>
.Ref the public documentation:
Is this correct?
Otherwise, I wonder if the async handling at
FAKE/src/app/Fake.Api.GitHub/GitHub.fs
Line 472 in fac7295
return! Async.AwaitTask
or maybe return theAsync.AwaitTask
directly without the extraasync {}
block?The text was updated successfully, but these errors were encountered: