Skip to content
This repository has been archived by the owner on Oct 31, 2021. It is now read-only.

VSLanguageService -> FSharp.Editing #1412

Open
cloudRoutine opened this issue Jul 13, 2016 · 1 comment
Open

VSLanguageService -> FSharp.Editing #1412

cloudRoutine opened this issue Jul 13, 2016 · 1 comment

Comments

@cloudRoutine
Copy link
Contributor

cloudRoutine commented Jul 13, 2016

Dependent upon completion of Open Documents Tracker #1410

Much of the functionality of the VSLanguageService can be moved to the LanguageService

  • unsure how to address buildQueryLexState, to start ignore the conditional branch that requires the ITextBuffer
  • EntityCache - Can this be re-implemented using a ConcurrentDictionary without the need for lock?
  • use FCSPoint & ranges instead of SnapshotPoint and SnapshotSpan
    *instead of passing the ITextView in GetLoadDirectiveFileNameAtCursor pass the caret position directly
  • unclear how to migrate and reportProgress from with FindUsages while in Core, save for end

Code Located @
https://github.com/fsprojects/VisualFSharpPowerTools/blob/master/src/FSharp.Editing.VisualStudio/ProjectSystem/VSLanguageService.fs
https://github.com/fsprojects/VisualFSharpPowerTools/blob/master/src/FSharp.Editing/ProjectSystem/LanguageService.fs

@cloudRoutine cloudRoutine added this to the VFPT.Core Refactoring milestone Jul 13, 2016
@vasily-kirichenko
Copy link
Contributor

I don't think LanguageService should accumulate more functionality. In fact, I'd like make it lighter. Feature specific code should be spread among other types.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants